From: Jonas Fonseca <fonseca@diku.dk>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] autoconf: Add -liconv to LIBS when NEEDS_LIBICONV
Date: Tue, 5 Sep 2006 18:25:26 +0200 [thread overview]
Message-ID: <20060905162526.GA5547@diku.dk> (raw)
In-Reply-To: <200609050055.52980.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> wrote Tue, Sep 05, 2006:
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Just in case; it could matter for testing if iconv is properly
> supported (NO_ICONV test).
>
> configure.ac | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 36f9cd9..fc5b813 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -147,6 +147,7 @@ AC_CHECK_LIB([c], [iconv],
> [NEEDS_LIBICONV=],
> [NEEDS_LIBICONV=YesPlease])
> AC_SUBST(NEEDS_LIBICONV)
> +test -n "$NEEDS_SOCKET" && LIBS="$LIBS -liconv"
I see that this has entered already, but it looks like it needs a
s/NEEDS_SOCKET/NEEDS_LIBICONV/
> #
> # Define NEEDS_SOCKET if linking with libc is not enough (SunOS,
> # Patrick Mauritz).
--
Jonas Fonseca
next prev parent reply other threads:[~2006-09-05 16:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 22:54 [PATCH 0/5] Some autoconf patches Jakub Narebski
2006-09-04 22:55 ` [PATCH 1/5] autoconf: Add some commented out variables to config.mak.in Jakub Narebski
2006-09-04 22:55 ` [PATCH 2/5] autoconf: Add -liconv to LIBS when NEEDS_LIBICONV Jakub Narebski
2006-09-05 16:25 ` Jonas Fonseca [this message]
2006-09-05 20:03 ` [PATCH] autoconf: Fix copy'n'paste error Jakub Narebski
2006-09-05 21:27 ` [PATCH 2/5] autoconf: Add -liconv to LIBS when NEEDS_LIBICONV Junio C Hamano
2006-09-04 22:56 ` [PATCH 3/5] autoconf: Preliminary check for working mmap Jakub Narebski
2006-09-04 23:36 ` Junio C Hamano
2006-09-04 23:43 ` Jakub Narebski
2006-09-05 3:09 ` Shawn Pearce
2006-09-05 5:10 ` Junio C Hamano
2006-09-05 6:25 ` Shawn Pearce
2006-09-05 7:43 ` Junio C Hamano
2006-09-06 3:40 ` Shawn Pearce
2006-09-06 7:17 ` Junio C Hamano
2006-09-06 8:15 ` Junio C Hamano
2006-09-07 5:58 ` Shawn Pearce
2006-09-04 22:57 ` [PATCH 4/5] autoconf: Check for subprocess.py Jakub Narebski
2006-09-04 22:58 ` [PATCH 5/5] autoconf: Quote AC_CACHE_CHECK arguments Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060905162526.GA5547@diku.dk \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.