From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Smith <sos22-xen@srcf.ucam.org>
Subject: Re: [PATCH] Paravirt framebuffer backend tools [2/5]
Date: Wed, 6 Sep 2006 10:14:12 +0100
Message-ID: <20060906091412.GC3257@cam.ac.uk>
References: <20060904090150.GC4812@cam.ac.uk>
	<1157472715.7571.88.camel@aglarond.local>
	<44FDAC68.8050205@cs.utexas.edu>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1656505165=="
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <44FDAC68.8050205@cs.utexas.edu>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Mime-version: 1.0
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Anthony Liguori <aliguori@cs.utexas.edu>
Cc: xen-devel <xen-devel@lists.xensource.com>, Jeremy Katz <katzj@redhat.com>, aliguori <aliguori@mail.utexas.edu>, Markus Armbruster <armbru@redhat.com>, sos22@srcf.ucam.org
List-Id: xen-devel@lists.xenproject.org


--===============1656505165==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Bu8it7iiRSEf40bY"
Content-Disposition: inline


--Bu8it7iiRSEf40bY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> >>>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> >>>+++ b/tools/xenfb/keymapping.c	Sat Sep 02 15:19:25 2006 -0400
> >>>@@ -0,0 +1,141 @@
> >>>+#include <stdint.h>
> >>>+#include <gdk/gdkkeysyms.h>
> >>>+#include <linux/input.h>
> >>>+
> >>>+uint32_t gdk_linux_mapping[0x10000] =3D {
> >>>+	[GDK_a] =3D KEY_A,
> >>>     =20
> >>This is kind of ugly.  Is there any chance it could be autogenerated?
> >>Also, where did 0x10000 come from?
> >>
> >>Also, depending on GTK just for the keymap table is a real pain.  Or
> >>is it already required for libvncserver?
> >>   =20
> >
> >libvncserver requires GTK.  And I don't know that there's really any
> >good way to auto-generate it unfortunately.  I somehow expect that
> >0x10000 came from "it'll be big enough" but Anthony would have to
> >confirm :-)
> That's the biggest that a GDK scan code can currently be.
Do you have a reference for that? Could the table grow in the future?

Steven
(who just spent a whole day tracking down a bug which turned out to be
an undersized lookup table combined with a lack of bounds checking)

> That way, we can use a simple indexed table.
>=20
> Regards,
>=20
> Anthony Liguori
>=20
> >The mappings are unfortunately a bit of a fact of life since we have to
> >convert from what the X layer gets to what the kernel expects.  And the
> >two couldn't be farther from the same.  And then it's even more fun when
> >toolkits get involved.
> > =20
>=20

--Bu8it7iiRSEf40bY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFE/pFkO4S8/gLNrjcRAh/xAJ0Uxs0PKklN9coUg5Dt5y0PLpKH8ACfauEH
skKqvbNg2a8u0uz+4FeSTGc=
=hhPD
-----END PGP SIGNATURE-----

--Bu8it7iiRSEf40bY--


--===============1656505165==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--===============1656505165==--