Re: [PATCH] Paravirt framebuffer backend tools [2/5]

[Steven Smith <sos22-xen@srcf.ucam.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1319 bytes --]

> Steven Smith wrote:
> [...]
> >> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> >> +++ b/tools/xenfb/keymapping.c	Sat Sep 02 15:19:25 2006 -0400
> >> @@ -0,0 +1,141 @@
> >> +#include <stdint.h>
> >> +#include <gdk/gdkkeysyms.h>
> >> +#include <linux/input.h>
> >> +
> >> +uint32_t gdk_linux_mapping[0x10000] = {
> >> +	[GDK_a] = KEY_A,
> > This is kind of ugly.  Is there any chance it could be autogenerated?
> > Also, where did 0x10000 come from?
> > 
> > Also, depending on GTK just for the keymap table is a real pain.  Or
> > is it already required for libvncserver?
> > 
> For the VNC part, as it depends on libvncserver, it should use
> /usr/include/rfb/keysym.h:
> 
> +uint32_t gdk_linux_mapping[0x10000] = {
> +	[XK_a] = KEY_A,
Yes, you're right.  The dependency on GTK is unimportant, but
libvncserver thinks it's generating X keysyms rather than GDK keys, so
XK_* is the correct thing to use, I think.

> For the SDL part, I'm sorry to repeat it should use scancode instead
> of symbol id ...
I think that would imply that the frontend would need to maintain its
own keymap, yes?  What do you think should happen if the system
running the SDL viewer has e.g. a French keyboard but the virtual
machine is configured with a US keymap?  Or have I misunderstood you?

Steven.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel