From: Stephen Hemminger <shemminger@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: stable@kernel.org, netdev@vger.kernel.org
Subject: [PATCH 2/6] sky2: clear status IRQ after empty
Date: Wed, 06 Sep 2006 10:17:54 -0700 [thread overview]
Message-ID: <20060906171920.866115000@localhost.localdomain> (raw)
In-Reply-To: 20060906171752.781595000@localhost.localdomain
[-- Attachment #1: sky2-status-clr.patch --]
[-- Type: text/plain, Size: 785 bytes --]
Don't clear status IRQ until list has been read to avoid causing
status list wraparound. Clearing IRQ forces a Transmit Status update
if it is pending.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- linux-2.6.17.11.orig/drivers/net/sky2.c
+++ linux-2.6.17.11/drivers/net/sky2.c
@@ -2016,6 +2016,9 @@ static int sky2_status_intr(struct sky2_
}
}
+ /* Fully processed status ring so clear irq */
+ sky2_write32(hw, STAT_CTRL, SC_STAT_CLR_IRQ);
+
exit_loop:
return work_done;
}
@@ -2218,9 +2221,6 @@ static int sky2_poll(struct net_device *
*budget -= work_done;
dev0->quota -= work_done;
- if (status & Y2_IS_STAT_BMU)
- sky2_write32(hw, STAT_CTRL, SC_STAT_CLR_IRQ);
-
if (sky2_more_work(hw))
return 1;
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-09-06 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 17:17 [PATCH 0/6] sky2 important fixes backport Stephen Hemminger
2006-09-06 17:17 ` [PATCH 1/6] sky2: accept flow control Stephen Hemminger
2006-09-06 17:17 ` Stephen Hemminger [this message]
2006-09-06 17:17 ` [PATCH 3/6] sky2: use dev_alloc_skb for receive buffers Stephen Hemminger
2006-09-06 17:17 ` [PATCH 4/6] sky2: MSI test timing Stephen Hemminger
2006-09-06 17:17 ` [PATCH 5/6] sky2: fix fiber support Stephen Hemminger
2006-09-06 17:17 ` [PATCH 6/6] sky2: version 1.6.1 Stephen Hemminger
2006-09-06 21:19 ` [stable] [PATCH 0/6] sky2 important fixes backport Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060906171920.866115000@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.