All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor@insightbb.com>
To: Daniel Ritz <daniel.ritz-ml@swissonline.ch>
Cc: Greg KH <gregkh@suse.de>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-usb <linux-usb-devel@lists.sourceforge.net>,
	Kai Lindholm <megantti@gmail.com>
Subject: Re: PATCH] usbtouchscreen: fix ITM data reading
Date: Thu, 7 Sep 2006 15:40:42 -0400	[thread overview]
Message-ID: <200609071540.43474.dtor@insightbb.com> (raw)
In-Reply-To: <200609072125.53404.daniel.ritz-ml@swissonline.ch>

On Thursday 07 September 2006 15:25, Daniel Ritz wrote:
> before 2.6.19, please :)
> 
> [PATCH] usbtouchscreen: fix ITM data reading
> 
> From: Kai Lindhom <megantti@gmail.com>
> Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
>

Acked-by: Dmitry Torokhov <dtor@mail.ru>

Greg, will you push it through your tree?
 
> diff --git a/drivers/usb/input/usbtouchscreen.c b/drivers/usb/input/usbtouchscreen.c
> index 3b175aa..a338bf4 100644
> --- a/drivers/usb/input/usbtouchscreen.c
> +++ b/drivers/usb/input/usbtouchscreen.c
> @@ -286,7 +286,7 @@ #ifdef CONFIG_USB_TOUCHSCREEN_ITM
>  static int itm_read_data(unsigned char *pkt, int *x, int *y, int *touch, int *press)
>  {
>  	*x = ((pkt[0] & 0x1F) << 7) | (pkt[3] & 0x7F);
> -	*x = ((pkt[1] & 0x1F) << 7) | (pkt[4] & 0x7F);
> +	*y = ((pkt[1] & 0x1F) << 7) | (pkt[4] & 0x7F);
>  	*press = ((pkt[2] & 0x1F) << 7) | (pkt[5] & 0x7F);
>  	*touch = ~pkt[7] & 0x20;
>  
> 

-- 
Dmitry

      reply	other threads:[~2006-09-07 19:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-07 19:25 PATCH] usbtouchscreen: fix ITM data reading Daniel Ritz
2006-09-07 19:40 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200609071540.43474.dtor@insightbb.com \
    --to=dtor@insightbb.com \
    --cc=daniel.ritz-ml@swissonline.ch \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=megantti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.