Re: [take17 1/4] kevent: Core files.

[shawvrana@gmail.com]

I stand corrected.

On Thursday 07 September 2006 23:38, Evgeniy Polyakov wrote:
> On Thu, Sep 07, 2006 at 09:05:16PM -0700, shaw@vranix.com (shaw@vranix.com) 
wrote:
> > > +static int __devinit kevent_user_init(void)
> > > +{
> > > +	int err = 0;
> > > +
> > > +	kevent_cache = kmem_cache_create("kevent_cache",
> > > +			sizeof(struct kevent), 0, SLAB_PANIC, NULL, NULL);
> > > +
> > > +	err = misc_register(&kevent_miscdev);
> > > +	if (err) {
> > > +		printk(KERN_ERR "Failed to register kevent miscdev: err=%d.\n",
> > > err); +		goto err_out_exit;
> > > +	}
> > > +
> > > +	printk("KEVENT subsystem has been successfully registered.\n");
> > > +
> > > +	return 0;
> > > +
> > > +err_out_exit:
> > > +	kmem_cache_destroy(kevent_cache);
> > > +	return err;
> > > +}
> >
> > It's probably best to treat kmem_cache_create like a black box and check
> > for it returning null.
>
> It can not return NULL, it will panic instead since I use SLAB_PANIC
> flag.
>
> > Thanks,
> > Shaw