All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: "Pádraig Brady" <P@draigBrady.com>,
	"Samuel Tardieu" <sam@rfc1149.net>,
	linux-kernel@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH] watchdog: add support for w83697hg chip
Date: Fri, 8 Sep 2006 14:22:49 +0200	[thread overview]
Message-ID: <20060908142249.f84ca41a.khali@linux-fr.org> (raw)
In-Reply-To: <45005657.8000509@gmail.com>

> Pádraig Brady wrote:
> > Is W83697HG a good name?
> >   
> 
> 
> could you add a suffix, say _watchdog ?
> 
> the name youve got is confusingly close to the convention used in 
> drivers/hwmon
> 
>  ls hwmon/w*.c
> hwmon/w83627ehf.c  hwmon/w83627hf.c  hwmon/w83781d.c  hwmon/w83791d.c  
> hwmon/w83792d.c  hwmon/w83l785ts.c

I second Jim's suggestion. Given the name of the other Winbond watchdog
drivers:

char/watchdog/w83627hf_wdt.c 
char/watchdog/w83977f_wdt.c
char/watchdog/w83877f_wdt.c

I'd suggest w83697hf_wdt.c. The W83697HG if the lead-free version of
the older W83697HF and they are otherwise the same chip. BTW I see that
there's already a driver for the W83627HF watchdog. Given the
similarities between the W83627HF and the W83697HF, it might make sense
to add support for the latter directly in the w83627hf_wdt driver,
rather than writing a brand new one.

-- 
Jean Delvare

  parent reply	other threads:[~2006-09-08 12:22 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-06 10:29 [PATCH] watchdog: add support for w83697hg chip Samuel Tardieu
2006-09-06 11:14 ` Pádraig Brady
2006-09-06 11:29   ` Samuel Tardieu
2006-09-06 11:49     ` Pádraig Brady
2006-09-06 12:07       ` Samuel Tardieu
2006-09-06 12:48         ` Pádraig Brady
2006-09-06 19:41         ` Wim Van Sebroeck
2006-09-07  9:57           ` Samuel Tardieu
2006-09-07 13:24             ` Pádraig Brady
2006-09-07 16:44             ` Samuel Tardieu
2006-09-08  9:16               ` Pádraig Brady
2006-09-08  9:49                 ` Samuel Tardieu
2006-09-07 17:26   ` Jim Cromie
2006-09-07 18:06     ` Samuel Tardieu
2006-09-08 12:22     ` Jean Delvare [this message]
2006-09-09 15:25 ` Alan Cox
2006-09-09 15:18   ` Samuel Tardieu
2006-09-09 15:33     ` Samuel Tardieu
2006-09-09 15:58     ` Alan Cox
2006-09-09 15:38       ` Samuel Tardieu
2006-09-09 16:28         ` Samuel Tardieu
2006-09-09 21:49           ` Alexey Dobriyan
2006-09-09 22:11             ` Samuel Tardieu
2006-09-09 22:27               ` Alexey Dobriyan
2006-09-09 18:02   ` [lm-sensors] " Sergey Vlasov
2006-09-09 18:02     ` Sergey Vlasov
2006-09-09 18:35     ` [lm-sensors] " Samuel Tardieu
2006-09-09 18:35       ` Samuel Tardieu
2006-09-11  5:50     ` [lm-sensors] " Evgeniy Polyakov
2006-09-11  5:50       ` Evgeniy Polyakov
2006-09-13 19:15     ` Wim Van Sebroeck
2006-09-14  7:15       ` Wim Van Sebroeck
2006-09-14  7:05     ` [lm-sensors] [RFC-patch 0/3] SuperIO locks coordinator (was: Jim Cromie
2006-09-14  7:05       ` [RFC-patch 0/3] SuperIO locks coordinator (was: watchdog: add support for w83697hg chip) Jim Cromie
2006-09-14  7:13       ` [lm-sensors] [RFC-patch 1/3] SuperIO locks coordinator Jim Cromie
2006-09-14  7:13         ` Jim Cromie
2006-09-17 17:23         ` [lm-sensors] " Randy.Dunlap
2006-09-17 17:23           ` Randy.Dunlap
2006-09-14  7:16       ` [lm-sensors] [RFC-patch 2/3] " Jim Cromie
2006-09-14  7:16         ` Jim Cromie
2006-09-14  7:20       ` [lm-sensors] [RFC-patch 3/3] SuperIO locks coordinator - use in Jim Cromie
2006-09-14  7:20         ` [RFC-patch 3/3] SuperIO locks coordinator - use in pc8736x_gpio Jim Cromie
2006-09-26  4:33         ` [lm-sensors] [RFC-patch 3/3] SuperIO locks coordinator - use in David Hubbard
2006-09-26 14:12         ` Jim Cromie
2006-09-14 21:58       ` [lm-sensors] [RFC-patch 0/3] SuperIO locks coordinator Jim Cromie
2006-09-14 21:58         ` Jim Cromie
2006-09-15  0:53       ` [lm-sensors] " David Hubbard
2006-09-15  7:23       ` Jim Cromie
2006-09-15 18:18       ` David Hubbard
2006-09-16 17:17         ` Jim Cromie
2006-09-16 17:17           ` Jim Cromie
2006-09-19 13:11       ` Samuel Tardieu
2006-09-19 13:11         ` Samuel Tardieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060908142249.f84ca41a.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=P@draigBrady.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@rfc1149.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.