From: Dipankar Sarma <dipankar@in.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] force_quiescent_state: factor out duplicated code
Date: Mon, 11 Sep 2006 02:33:48 +0530 [thread overview]
Message-ID: <20060910210348.GE4690@in.ibm.com> (raw)
In-Reply-To: <20060910161810.GA10262@oleg>
On Sun, Sep 10, 2006 at 08:18:10PM +0400, Oleg Nesterov wrote:
> On top of rcu-simplify-improve-batch-tuning.patch
>
> Cleanup. Move '#ifdef CONFIG_SMP' check and rdp->bhlimit setting
> into force_quiescent_state().
Pushing the rdp->blimit setting into force_quiescent_state is fine,
but I see no need to insert #ifdef CONFIG_SMP into a routine.
Let us continue to have separate versions of force_quiescent_state()
for CONFIG_SMP and !CONFIG_SMP. It looks cleaner with #ifdefs inserted
in between.
Thanks
Dipankar
next prev parent reply other threads:[~2006-09-10 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-10 16:18 [PATCH] force_quiescent_state: factor out duplicated code Oleg Nesterov
2006-09-10 21:03 ` Dipankar Sarma [this message]
2006-09-10 21:13 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060910210348.GE4690@in.ibm.com \
--to=dipankar@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=paulmck@us.ibm.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.