From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Split multi-line printk in oops output.
Date: Mon, 11 Sep 2006 22:24:38 +0200 [thread overview]
Message-ID: <200609112224.38726.ak@suse.de> (raw)
In-Reply-To: <20060911060755.GA8271@redhat.com>
On Monday 11 September 2006 08:07, Dave Jones wrote:
> On Mon, Sep 11, 2006 at 07:44:15AM +0200, Andi Kleen wrote:
> > > print_modules();
> > > - printk(KERN_EMERG "CPU: %d\nEIP: %04x:[<%08lx>] %s VLI\n"
> > > - "EFLAGS: %08lx (%s %.*s) \n",
> > > - smp_processor_id(), 0xffff & regs->xcs, regs->eip,
> > > - print_tainted(), regs->eflags, system_utsname.release,
> > > + printk(KERN_EMERG "CPU: %d\n", smp_processor_id());
> > > + printk(KERN_EMERG "EIP: %04x:[<%08lx>] %s VLI\n",
> > > + 0xffff & regs->xcs, regs->eip, print_tainted());
> > > + printk(KERN_EMERG "EFLAGS: %08lx (%s %.*s)\n",
> >
> > Still only using a single printk would be slightly safer
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Added thanks., Please include the full description on reposted patches
in the future too.
-Andi
prev parent reply other threads:[~2006-09-11 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 3:07 Split multi-line printk in oops output Dave Jones
2006-09-11 5:44 ` Andi Kleen
2006-09-11 6:07 ` Dave Jones
2006-09-11 20:24 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609112224.38726.ak@suse.de \
--to=ak@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.