From: Dmitry Torokhov <dtor@insightbb.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] raw: return negative from raw_init()
Date: Mon, 11 Sep 2006 23:34:19 -0400 [thread overview]
Message-ID: <200609112334.19998.dtor@insightbb.com> (raw)
In-Reply-To: <20060912011918.GC5192@martell.zuzino.mipt.ru>
On Monday 11 September 2006 21:19, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/char/raw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/char/raw.c
> +++ b/drivers/char/raw.c
> @@ -312,7 +312,7 @@ static int __init raw_init(void)
>
> error:
> printk(KERN_ERR "error register raw device\n");
> - return 1;
> + return -1;
> }
>
How about reworking it a bit to pass true error code from the failed
call? Additionally class_device_create call is not checked for errors
there.
--
Dmitry
next prev parent reply other threads:[~2006-09-12 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 1:19 [PATCH] raw: return negative from raw_init() Alexey Dobriyan
2006-09-12 3:34 ` Dmitry Torokhov [this message]
2006-09-14 21:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609112334.19998.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.