All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] - restore i8259A eoi status on resume
Date: Tue, 12 Sep 2006 13:47:42 +0100	[thread overview]
Message-ID: <20060912124742.GB31344@srcf.ucam.org> (raw)
In-Reply-To: <20060912091906.GB19482@elf.ucw.cz>

On Tue, Sep 12, 2006 at 11:19:06AM +0200, Pavel Machek wrote:
> Hi!
> 
> > Got it. i8259A_resume calls init_8259A(0) unconditionally, even if 
> > auto_eoi has been set. Keep track of the current status and restore that 
> > on resume. This fixes it for AMD64 and i386.
> 
> Patch looks okay to me...

Cool. Andi, does it look sane to you? I'm not really sure who to wave 
8259 code at...

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2006-09-12 12:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-10 14:15 io-apic breaks suspend unless acpi_skip_timer_override Matthew Garrett
2006-09-10 20:58 ` Pavel Machek
2006-09-10 21:20   ` Matthew Garrett
2006-09-10 22:33     ` Pavel Machek
2006-09-11  0:31       ` io-apic - no timer ticks after resume on IXP200 Matthew Garrett
2006-09-11  5:46         ` Andi Kleen
2006-09-11 11:05           ` Matthew Garrett
2006-09-11 20:02             ` Andi Kleen
2006-09-11 22:23               ` Matthew Garrett
2006-09-11 23:07                 ` [PATCH] - restore i8259A eoi status on resume Matthew Garrett
2006-09-12  9:19                   ` Pavel Machek
2006-09-12 12:47                     ` Matthew Garrett [this message]
2006-09-12 12:11                       ` Andi Kleen
2006-09-12 13:40                         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060912124742.GB31344@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=ak@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.