From: Olof Johansson <olof@lixom.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org
Subject: Re: [Cbe-oss-dev] [PATCH] powerpc: allow PHBs anywhere in the device tree
Date: Tue, 12 Sep 2006 16:44:43 -0500 [thread overview]
Message-ID: <20060912164443.231bc01e@localhost.localdomain> (raw)
In-Reply-To: <200609122316.21820.arnd@arndb.de>
On Tue, 12 Sep 2006 23:16:21 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 12 September 2006 21:54, Olof Johansson wrote:
> > !strcasecmp(...) instead?
>
> I do that normally for functions that return either a truth value
> or a pointer to an object that may be NULL, whereas strcasecmp
> returns a numerical value that I'm checking for a specific result.
> This is also consistant with how it is used elsewhere in the file.
Ok.
> > Do they ever exist in non-lowercase versions? Old code just did
> > strcmp().
>
> I took that from device_is_compatible(), which also does
> strncasecmp, so I assumed that was done for a reason.
I think it might be because compatible is by tradition less specific. I
was also mostly looking at the patch, not the rest of the file. Either
is fine with me though, I just wanted to bring it up.
-Olof
next prev parent reply other threads:[~2006-09-12 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 17:52 [PATCH] powerpc: allow PHBs anywhere in the device tree Arnd Bergmann
2006-09-12 19:54 ` Olof Johansson
2006-09-12 21:16 ` [Cbe-oss-dev] " Arnd Bergmann
2006-09-12 21:44 ` Olof Johansson [this message]
2006-09-12 22:20 ` Paul Mackerras
2006-09-12 22:39 ` [Cbe-oss-dev] " Arnd Bergmann
2006-09-13 1:46 ` Benjamin Herrenschmidt
2006-09-13 0:23 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060912164443.231bc01e@localhost.localdomain \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.