From: Martin Langer <martin-langer@gmx.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de,
Michael Buesch <mb@bu3sch.de>, Stefano Brivio <st3@riseup.net>
Subject: Re: [PATCH] bcm43xx-softmac: improve wrong firmware message
Date: Tue, 12 Sep 2006 23:49:39 +0200 [thread overview]
Message-ID: <20060912214939.GA3750@tuba> (raw)
In-Reply-To: <45071890.mailJEJ1PQOHG@lwfinger.net>
On Tue, Sep 12, 2006 at 03:29:04PM -0500, Larry Finger wrote:
> An error message is changed to a printk as the original dprintk would
> be optimized away if debugging were not enabled. If the error is triggered,
> a more meaningful message is returned.
>
>
> if ( value16 > 0x128 ) {
> - dprintk(KERN_ERR PFX
> - "Firmware: no support for microcode rev > 0x128\n");
> - err = -1;
> + printk(KERN_ERR PFX
> + "Firmware: no support for microcode extracted "
> + "from version 4.x binary drivers.\n");
Why not writing both (ucode rev and driver version)? Something like
"from version 4.x binary drivers (rev>0x128).\n"
BTW, if anybody needs the relationship between ucode revsion and driver
version then he should look at the table here:
http://www.langerland.de/linux/bcm43xx/firmware.html
Martin
next prev parent reply other threads:[~2006-09-12 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 20:29 [PATCH] bcm43xx-softmac: improve wrong firmware message Larry Finger
2006-09-12 21:49 ` Martin Langer [this message]
2006-09-12 22:06 ` Larry Finger
[not found] ` <45072F4D.80109-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-09-13 12:31 ` Michael Buesch
2006-09-14 14:00 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060912214939.GA3750@tuba \
--to=martin-langer@gmx.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=st3@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.