All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: viro@ftp.linux.org.uk
Cc: herbert@gondor.apana.org.au, torvalds@osdl.org, netdev@vger.kernel.org
Subject: Re: ipip and ip_gre encapsulation bugs
Date: Wed, 13 Sep 2006 21:03:22 -0700 (PDT)	[thread overview]
Message-ID: <20060913.210322.78723655.davem@davemloft.net> (raw)
In-Reply-To: <20060914011637.GH29920@ftp.linux.org.uk>

From: Al Viro <viro@ftp.linux.org.uk>
Date: Thu, 14 Sep 2006 02:16:37 +0100

> OK, after rereading the RFC...  Pointer field is one octet, indeed.
> Avoiding all swapping will be tough - icmp_send() takes 32bit argument,
> net-endian.

Thanks for the fix Al, but did you notice that this code is totally
unused?  It's a code block commented out by a large ifdef, such that
the code block is never enabled and serves as example code we
could use if some limitations in the current internet did not
exist. :-)

But thanks anyways, I'll queue this up for 2.6.19

      reply	other threads:[~2006-09-14  4:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-12 16:50 ipip and ip_gre encapsulation bugs Al Viro
2006-09-14  0:23 ` Herbert Xu
2006-09-14  1:16   ` Al Viro
2006-09-14  4:03     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060913.210322.78723655.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.