All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Oeser <netdev@axxeo.de>
To: Tim Hockin <thockin@hockin.org>
Cc: netdev@vger.kernel.org
Subject: [PATCH] natsemi: Messages being noisy
Date: Wed, 13 Sep 2006 15:28:51 +0200	[thread overview]
Message-ID: <200609131528.51336.netdev@axxeo.de> (raw)

Hi there,

I  get the following message when trying to transfer big files 
(via FTP or SCP) since Linux 2.6.16.27. It didn't happen with Linux 2.6.13.4.

[702238.242237] eth1: increased tx threshold, txcfg 0xd0f01008.
[702238.242649] eth1: increased tx threshold, txcfg 0xd0f0100a.

What about putting this message at the message level "DEBUG"
or even under pr_debug()?

This NIC is just used for PPPoE in our setups.

The other message "tx underrun with maximum tx threshold"
is much more useful, since it indicates a real problem.

So I would suggest the following patch:

Signed-off-by: Ingo Oeser <netdev@axxeo.de>

--- linux-2.6.16.28/drivers/net/natsemi.c~	2006-08-25 22:51:14.000000000 +0200
+++ linux-2.6.16.28/drivers/net/natsemi.c	2006-09-13 15:26:24.995044665 +0200
@@ -2338,8 +2338,7 @@
 		if ((np->tx_config & TxDrthMask) < TX_DRTH_VAL_LIMIT) {
 			np->tx_config += TX_DRTH_VAL_INC;
 			if (netif_msg_tx_err(np))
-				printk(KERN_NOTICE
-					"%s: increased tx threshold, txcfg %#08x.\n",
+				pr_debug("%s: increased tx threshold, txcfg %#08x.\n",
 					dev->name, np->tx_config);
 		} else {
 			if (netif_msg_tx_err(np))

             reply	other threads:[~2006-09-13 13:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-13 13:28 Ingo Oeser [this message]
2006-09-14 15:39 ` [PATCH] natsemi: Messages being noisy Ingo Oeser
2006-09-14 15:46   ` thockin
2006-09-15  8:11     ` Ingo Oeser
2006-09-15 10:52     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200609131528.51336.netdev@axxeo.de \
    --to=netdev@axxeo.de \
    --cc=netdev@vger.kernel.org \
    --cc=thockin@hockin.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.