All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Fasheh <mark.fasheh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] cluster/heartbeat.c::compute_max_sectors is invalid.
Date: Wed Sep 13 11:17:41 2006	[thread overview]
Message-ID: <20060913181737.GH8792@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20060913104442.6d8a541b@mathieu.toulouse>

On Wed, Sep 13, 2006 at 10:44:42AM +0200, Mathieu Avila wrote:
> A proposal patch (against the 2.6.17.11 vanilla kernel) for this is
> attached. It works for me, and shouldn't break any existing device.
Ok, that patch looks good - I've put it in my 2.6.19 queue.


> And i still think that it is a bad idea to try figuring out how many
> BIOs are needed, because it really depends on the underlying
> architecture of the device. Although it might work on most hardware,
> some strange one might break one day...
Well, I'm pretty sure some other software uses that approach, but that might
just mean other software might have similar problems :)

So yeah. I don't reallly have any qualms changing ocfs2 heartbeat to a more
"natural" usage of the bio API.


Thanks!
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com

      reply	other threads:[~2006-09-13 11:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-07  3:10 [Ocfs2-devel] cluster/heartbeat.c::compute_max_sectors is invalid Mathieu Avila
2006-09-08 11:28 ` Mark Fasheh
2006-09-13  1:44   ` Mathieu Avila
2006-09-13 11:17     ` Mark Fasheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060913181737.GH8792@ca-server1.us.oracle.com \
    --to=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.