From: Dmitry Torokhov <dtor@insightbb.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Greg K-H <greg@kroah.com>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [03/12] driver core fixes: fixup platform_device_register_simple()
Date: Wed, 13 Sep 2006 22:31:05 -0400 [thread overview]
Message-ID: <200609132231.06346.dtor@insightbb.com> (raw)
In-Reply-To: <20060913183840.5a2e4989@gondolin.boeblingen.de.ibm.com>
Hi,
On Wednesday 13 September 2006 12:38, Cornelia Huck wrote:
> From: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> Remember to remove allocated resources if platform_device_add() fails.
> Introduce a helper function platform_device_del_resources() for this,
> which can also be used by platform_device_del().
>
platform_device_add() already releases all resources in case of failure.
Memory allocated for resource structures is released by
platform_device_release(). I do not think this patch is needed.
As fas as platform_device_register_somple() goes it should just die and
users should be converted to platofrm_device_alloc/add.
--
Dmitry
next prev parent reply other threads:[~2006-09-14 2:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060913163007.21cf10a8@gondolin.boeblingen.de.ibm.com>
2006-09-13 16:38 ` [01/12] driver core fixes: make_class_name() retval check Cornelia Huck
2006-09-14 12:01 ` Martin Waitz
2006-09-15 11:20 ` Cornelia Huck
2006-09-13 16:38 ` [02/12] driver core fixes: device_register() retval check in platform.c Cornelia Huck
2006-09-13 16:38 ` [03/12] driver core fixes: fixup platform_device_register_simple() Cornelia Huck
2006-09-14 2:31 ` Dmitry Torokhov [this message]
2006-09-14 7:06 ` Cornelia Huck
2006-09-13 16:38 ` [04/12] driver core fixes: retval check in class_register() Cornelia Huck
2006-09-13 16:38 ` [05/12] driver core fixes: sysfs_create_link() retval check in class.c Cornelia Huck
2006-09-13 16:38 ` [06/12] driver core fixes: bus_add_attrs() retval check Cornelia Huck
2006-09-13 16:38 ` [07/12] driver core fixes: bus_add_device() cleanup on error Cornelia Huck
[not found] ` <1158168423.14312.16.camel@localhost>
2006-09-14 7:40 ` Cornelia Huck
2006-09-13 16:38 ` [08/12] driver core fixes: device_add() " Cornelia Huck
2006-09-13 16:38 ` [09/12] driver core fixes: bus_attach_device() retval check Cornelia Huck
2006-09-13 16:39 ` [10/12] driver core fixes: sysfs_create_link() retval check in core.c Cornelia Huck
[not found] ` <1158168842.14312.18.camel@localhost>
2006-09-14 7:43 ` Cornelia Huck
2006-09-13 16:39 ` [11/12] driver core fixes: device_create_file() retval check in dmapool.c Cornelia Huck
2006-09-13 16:39 ` [12/12] driver core fixes: sysfs_create_group() retval in topology.c Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609132231.06346.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=cornelia.huck@de.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.