All of lore.kernel.org
 help / color / mirror / Atom feed
From: adas@sourceware.org <adas@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/dlm plock.c
Date: 14 Sep 2006 16:00:29 -0000	[thread overview]
Message-ID: <20060914160029.1273.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4U4
Changes by:	adas at sourceware.org	2006-09-14 16:00:28

Modified files:
	gfs-kernel/src/dlm: plock.c 

Log message:
	fix for bz 206339. Was passing fl_pid instead of fl_owner causing F_GETLK to return conflicts with a process' own locks

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/dlm/plock.c.diff?cvsroot=cluster&only_with_tag=RHEL4U4&r1=1.12.14.1&r2=1.12.14.2

--- cluster/gfs-kernel/src/dlm/Attic/plock.c	2006/07/12 21:50:26	1.12.14.1
+++ cluster/gfs-kernel/src/dlm/Attic/plock.c	2006/09/14 16:00:27	1.12.14.2
@@ -753,7 +753,7 @@
    shrink, shift, split, etc existing locks (this often involves adding new
    locks in addition to modifying existing locks. */
 
-static int plock_internal(struct dlm_resource *r, unsigned long owner,
+static int plock_internal(struct dlm_resource *r, unsigned long owner, 
 			  unsigned int pid, int wait, int ex, uint64_t start, 
 			  uint64_t end)
 {
@@ -1179,7 +1179,7 @@
 			put_resource(r);
 			goto out;
 		}
-
+		
 		found = get_local_conflict(dlm, r, name, owner, start, end, ex,
 					   rowner, rpid);
 		up(&r->sema);
@@ -1187,7 +1187,7 @@
 		if (found) {
 			error = 1;
 			goto out;
-	}
+		}
 	}
 
 	error = get_global_conflict(dlm, name, owner, start, end, ex, rowner, rpid);
@@ -1236,7 +1236,7 @@
 
 	ex = (fl->fl_type == F_WRLCK) ? 1 : 0;
 
-	error = do_plock_get(dlm, name, fl->fl_pid, &fl->fl_start,
+	error = do_plock_get(dlm, name, fl->fl_owner, &fl->fl_start,
 			     &fl->fl_end, &ex, &owner, &pid);
 	if (error < 0)
 		return error;



             reply	other threads:[~2006-09-14 16:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 16:00 adas [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-09-15 17:43 [Cluster-devel] cluster/gfs-kernel/src/dlm plock.c adas
2006-09-15 17:43 adas
2006-09-15 17:42 adas
2006-09-14 16:00 adas
2006-09-14 16:00 adas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060914160029.1273.qmail@sourceware.org \
    --to=adas@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.