Re: [PATCH] Paravirt framebuffer support in xend [3/5]

["Daniel P. Berrange" <berrange@redhat.com>]

On Sat, Sep 02, 2006 at 03:58:37PM -0400, Jeremy Katz wrote:
> Add support in xend and xm to know about the vnc and sdl options for PV
> domains.  Launch xen-sdlfb or xen-vncfb if we're setting up a graphics
> console.  Also, if we're going to use a graphical console in the guest,
> set /<dompath>/console/use_graphics to 1.

I've found a bit of a problematic interaction between the SEXPR for VNC
and bootloaders. The VNC related bit of the SEXPR is within the image
part, eg 

  (image 
    (linux 
       (kernel '/var/lib/xen/vmlinuz.RSa3-O')
       (ramdisk '/var/lib/xen/initrd.ndZEf8')
       (vnc 1)
       (vncdisplay 9)
    )
  )

If I'm using a bootloader though, the SEXPR I send to XenD does not even
contain a '(image (linux ...))' block so there is no place to specify the
VNC options. The hack of trying to supply a (image) section within a
kernel doesn't work:

  (bootloader '/usr/bin/pygrub')
  (image
    (linux 
       (vnc 1)
       (vncdisplay 9)
    )
  )


Because if XenD finds a 'image' node in the SEXPR it ignores the bootloader
settings & assumes there is a (kernel) bit. Now we could hack it so that
XenD can handle a (image) bit without a kernel specified, but really this
is far from optimal. 

IMHO the VNC console options have no business being anywhere near the (image)
bit of the SEXPR since they're nothing todo with kernel images whatsoever.
Of course I understand why the PV framebuffer puts them here - its just
copying existing HVM style, but that doesn't make it a good idea. I think
we'd be better off having the framebuffer related stuff as a fully-fledged
part of the (device) SEXPR block.

So this raises two questions, do we want to re-arrange the SEXPR to have
VNC opts in a sensible part, or is there a way we can make existing scheme
work nicely with bootloaders.


NB, the reason that 'xm' can create domains with the framebuffer active,
and using the bootloader is because xm runs 'pygrub' client side& then
munges the SEXPR before sending it to XenD. The problem occurrs only if
you are running pygrub server-side (ie letting XenD run it) because then
there is no way to specify any console options due to missing (image)
block.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|