From: Jarek Poplawski <jarkao2@o2.pl>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@muc.de>, Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mpparse.c:231: warning: comparison is always false
Date: Fri, 15 Sep 2006 11:08:19 +0200 [thread overview]
Message-ID: <20060915090819.GB2572@ff.dom.local> (raw)
In-Reply-To: <20060915012302.d459c2dc.akpm@osdl.org>
On Fri, Sep 15, 2006 at 01:23:02AM -0700, Andrew Morton wrote:
> On Fri, 15 Sep 2006 10:11:23 +0200
> Jarek Poplawski <jarkao2@o2.pl> wrote:
> > As a matter of fact today I think my patch is wrong.
...
> No, I think it's OK. Well, you had an off-by-one...
just like the source:
> +#if 0xFF >= MAX_MP_BUSSES
> if (m->mpc_busid >= MAX_MP_BUSSES) {
...
> > but after rethinking
> > the question of Dave Jones I see it's fixing the result
> > instead of the source of a problem (char or not char).
>
> The mpc_busid field is set to eight-bits by BIOS; there's nothing we can do
> about that...
So IMHO maybe: if we can know this only by BIOS it should be
eight-bits - if there is another way to get this: shouln't
you add second constant? Now it's unlogical for me (and it
induces this strange #ifs in the code instead of headers).
Jarek P.
next prev parent reply other threads:[~2006-09-15 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-13 6:50 [PATCH] mpparse.c:231: warning: comparison is always false Jarek Poplawski
2006-09-13 16:42 ` Dave Jones
2006-09-14 5:36 ` Jarek Poplawski
2006-09-14 6:35 ` Dave Jones
2006-09-14 7:36 ` Jarek Poplawski
2006-09-14 10:12 ` Andi Kleen
2006-09-14 16:08 ` Dave Jones
2006-09-15 6:43 ` Andi Kleen
[not found] ` <20060914181754.bd963f6d.akpm@osdl.org>
2006-09-15 8:11 ` Jarek Poplawski
2006-09-15 8:23 ` Andrew Morton
2006-09-15 9:08 ` Jarek Poplawski [this message]
2006-09-15 15:23 ` Dave Jones
2006-09-15 19:33 ` Andrew Morton
2006-09-16 6:19 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060915090819.GB2572@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.