All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederik Deweerdt <deweerdt@free.fr>
To: David Howells <dhowells@redhat.com>
Cc: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: [-mm patch] add missing page_copy export for ppc and powerpc (was Re: cachefiles on latest -mm fails to build on powerpc)
Date: Fri, 15 Sep 2006 17:58:56 +0000	[thread overview]
Message-ID: <20060915175856.GF2876@slug> (raw)
In-Reply-To: <5069.1158334773@warthog.cambridge.redhat.com>

On Fri, Sep 15, 2006 at 04:39:33PM +0100, David Howells wrote:
> Frederik Deweerdt <deweerdt@free.fr> wrote:
> 
> > +EXPORT_SYMBOL(copy_page);
> 
> But only if !__powerpc64__.  Otherwise you need copy_4K_page to be exported
> instead.
> 
Oops, thanks, here's a corrected patch. From a quick look, it seems that
the ppc needs the same kind of export.
This adds a missing copy_page export for the powerpc and ppc arches.

Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>

diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
index 39d3bfc..23ccd5d 100644
--- a/arch/powerpc/kernel/ppc_ksyms.c
+++ b/arch/powerpc/kernel/ppc_ksyms.c
@@ -93,6 +93,12 @@ EXPORT_SYMBOL(__strncpy_from_user);
 EXPORT_SYMBOL(__strnlen_user);
 
 #ifndef  __powerpc64__
+EXPORT_SYMBOL(copy_page);
+#else
+EXPORT_SYMBOL(copy_4K_page);
+#endif
+
+#ifndef  __powerpc64__
 EXPORT_SYMBOL(__ide_mm_insl);
 EXPORT_SYMBOL(__ide_mm_outsw);
 EXPORT_SYMBOL(__ide_mm_insw);
diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
index d173540..3045cc3 100644
--- a/arch/ppc/kernel/ppc_ksyms.c
+++ b/arch/ppc/kernel/ppc_ksyms.c
@@ -106,6 +106,8 @@ EXPORT_SYMBOL(__clear_user);
 EXPORT_SYMBOL(__strncpy_from_user);
 EXPORT_SYMBOL(__strnlen_user);
 
+EXPORT_SYMBOL(copy_page);
+
 /*
 EXPORT_SYMBOL(inb);
 EXPORT_SYMBOL(inw);

  reply	other threads:[~2006-09-15 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-15 12:31 cachefiles on latest -mm fails to build on powerpc Aristeu Sergio Rozanski Filho
2006-09-15 15:50 ` Frederik Deweerdt
2006-09-15 15:17   ` Aristeu Sergio Rozanski Filho
2006-09-15 17:35     ` Frederik Deweerdt
2006-09-15 15:39       ` David Howells
2006-09-15 17:58         ` Frederik Deweerdt [this message]
2006-09-15 17:33           ` [-mm patch] add missing page_copy export for ppc and powerpc (was Re: cachefiles on latest -mm fails to build on powerpc) Aristeu Sergio Rozanski Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060915175856.GF2876@slug \
    --to=deweerdt@free.fr \
    --cc=akpm@osdl.org \
    --cc=aris@cathedrallabs.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.