diff for duplicates of <200609172121.36247.dtor@insightbb.com> diff --git a/a/1.txt b/N1/1.txt index 8df1f00..36798ae 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,39 @@ -On Sunday 17 September 2006 20:54, Om Narasimhan wrote:> --- a/drivers/bluetooth/hci_usb.c> +++ b/drivers/bluetooth/hci_usb.c> @@ -147,10 +147,9 @@ static struct usb_device_id blacklist_id> > static struct _urb *_urb_alloc(int isoc, gfp_t gfp)> {> - struct _urb *_urb = kmalloc(sizeof(struct _urb) +> + struct _urb *_urb = kzalloc(sizeof(struct _urb) +> sizeof(struct usb_iso_packet_descriptor) * isoc, gfp);> if (_urb) {> - memset(_urb, 0, sizeof(*_urb));> usb_init_urb(&_urb->urb);> }> return _urb;> -Note that only beginning if the aloocated memory was zeroed in originalcode; your patch may introduce slowdowns. --- Dmitry +On Sunday 17 September 2006 20:54, Om Narasimhan wrote: +> --- a/drivers/bluetooth/hci_usb.c +> +++ b/drivers/bluetooth/hci_usb.c +> @@ -147,10 +147,9 @@ static struct usb_device_id blacklist_id +> = + +> =A0static struct _urb *_urb_alloc(int isoc, gfp_t gfp) +> =A0{ +> -=A0=A0=A0=A0=A0=A0=A0struct _urb *_urb =3D kmalloc(sizeof(struct _urb) + +> +=A0=A0=A0=A0=A0=A0=A0struct _urb *_urb =3D kzalloc(sizeof(struct _urb) + +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= +=A0=A0=A0=A0=A0=A0=A0=A0sizeof(struct usb_iso_packet_descriptor) * isoc, gf= +p); +> =A0=A0=A0=A0=A0=A0=A0=A0if (_urb) { +> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0memset(_urb, 0, sizeof(*_ur= +b)); +> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0usb_init_urb(&_urb->urb); +> =A0=A0=A0=A0=A0=A0=A0=A0} +> =A0=A0=A0=A0=A0=A0=A0=A0return _urb; +> = + + +Note that only beginning if the aloocated memory was zeroed in original +code; your patch may introduce slowdowns. + +-- = + +Dmitry +------------------------------------------------------------------------- +Using Tomcat but need to do more? Need to support web services, security? +Get stuff done quickly with pre-integrated technology to make your job easi= +er +Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo +http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1= +21642 _______________________________________________ -Kernel-janitors mailing list -Kernel-janitors@lists.osdl.org -https://lists.osdl.org/mailman/listinfo/kernel-janitors +Bluez-devel mailing list +Bluez-devel@lists.sourceforge.net +https://lists.sourceforge.net/lists/listinfo/bluez-devel diff --git a/a/content_digest b/N1/content_digest index 81f8725..d18465f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,51 @@ "ref\06b4e42d10609171754q7c7335f9pfab703d6b746236b@mail.gmail.com\0" "From\0Dmitry Torokhov <dtor@insightbb.com>\0" - "Subject\0Re: [KJ] bluetooth drivers : kmalloc to kzalloc conversion\0" - "Date\0Mon, 18 Sep 2006 01:21:33 +0000\0" + "Subject\0Re: [Bluez-devel] bluetooth drivers : kmalloc to kzalloc conversion\0" + "Date\0Sun, 17 Sep 2006 21:21:33 -0400\0" "To\0Om Narasimhan <om.turyx@gmail.com>\0" "Cc\0kernel-janitors@lists.osdl.org" linux-kernel@vger.kernel.org " bluez-devel@lists.sf.net\0" "\00:1\0" "b\0" - "On Sunday 17 September 2006 20:54, Om Narasimhan wrote:> --- a/drivers/bluetooth/hci_usb.c> +++ b/drivers/bluetooth/hci_usb.c> @@ -147,10 +147,9 @@ static struct usb_device_id blacklist_id> > \302\240static struct _urb *_urb_alloc(int isoc, gfp_t gfp)> \302\240{> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct _urb *_urb = kmalloc(sizeof(struct _urb) +> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct _urb *_urb = kzalloc(sizeof(struct _urb) +> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240sizeof(struct usb_iso_packet_descriptor) * isoc, gfp);> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (_urb) {> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240memset(_urb, 0, sizeof(*_urb));> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240usb_init_urb(&_urb->urb);> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return _urb;> \n" - "Note that only beginning if the aloocated memory was zeroed in originalcode; your patch may introduce slowdowns.\n" - "-- Dmitry\n" + "On Sunday 17 September 2006 20:54, Om Narasimhan wrote:\n" + "> --- a/drivers/bluetooth/hci_usb.c\n" + "> +++ b/drivers/bluetooth/hci_usb.c\n" + "> @@ -147,10 +147,9 @@ static struct usb_device_id blacklist_id\n" + "> =\n" + "\n" + "> =A0static struct _urb *_urb_alloc(int isoc, gfp_t gfp)\n" + "> =A0{\n" + "> -=A0=A0=A0=A0=A0=A0=A0struct _urb *_urb =3D kmalloc(sizeof(struct _urb) +\n" + "> +=A0=A0=A0=A0=A0=A0=A0struct _urb *_urb =3D kzalloc(sizeof(struct _urb) +\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=\n" + "=A0=A0=A0=A0=A0=A0=A0=A0sizeof(struct usb_iso_packet_descriptor) * isoc, gf=\n" + "p);\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0if (_urb) {\n" + "> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0memset(_urb, 0, sizeof(*_ur=\n" + "b));\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0usb_init_urb(&_urb->urb);\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0}\n" + "> =A0=A0=A0=A0=A0=A0=A0=A0return _urb;\n" + "> =\n" + "\n" + "\n" + "Note that only beginning if the aloocated memory was zeroed in original\n" + "code; your patch may introduce slowdowns.\n" + "\n" + "-- =\n" + "\n" + "Dmitry\n" + "-------------------------------------------------------------------------\n" + "Using Tomcat but need to do more? Need to support web services, security?\n" + "Get stuff done quickly with pre-integrated technology to make your job easi=\n" + "er\n" + "Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo\n" + "http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D1=\n" + "21642\n" "_______________________________________________\n" - "Kernel-janitors mailing list\n" - "Kernel-janitors@lists.osdl.org\n" - https://lists.osdl.org/mailman/listinfo/kernel-janitors + "Bluez-devel mailing list\n" + "Bluez-devel@lists.sourceforge.net\n" + https://lists.sourceforge.net/lists/listinfo/bluez-devel -c8d94f2a109329a25917128c6ebfcbe50fde0a0c4efc29de2d1693b4f1838e57 +3324cd51400e54d2da32ca7682914f1ffb788872823b17470cc1c5ea480c23af
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.