All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20060921072017.GA27798@us.ibm.com>

diff --git a/a/1.txt b/N1/1.txt
index ae64b70..9ea3acf 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -34,7 +34,7 @@ patch, most importantly.
 >  			if (iocommand.buf_size > 0) {
 > -				buff = kmalloc(iocommand.buf_size, GFP_KERNEL);
 > +				buff = kzalloc(iocommand.buf_size, GFP_KERNEL);
->  				if (buff = NULL)
+>  				if (buff == NULL)
 >  					return -EFAULT;
 >  			}
 > @@ -911,8 +911,6 @@ #endif
@@ -44,11 +44,11 @@ patch, most importantly.
 > -			} else {
 > -				memset(buff, 0, iocommand.buf_size);
 >  			}
->  			if ((c = cmd_alloc(host, 0)) = NULL) {
+>  			if ((c = cmd_alloc(host, 0)) == NULL) {
 >  				kfree(buff);
 
 This changes performance potentially, no? The memset before was
-conditional upon (iocommand.Request.Type.Direction = XFER_WRITE) and
+conditional upon (iocommand.Request.Type.Direction == XFER_WRITE) and
 now the memory will always be zero'd.
 
 > diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
@@ -99,7 +99,3 @@ Nish
 -- 
 Nishanth Aravamudan <nacc@us.ibm.com>
 IBM Linux Technology Center
-_______________________________________________
-Kernel-janitors mailing list
-Kernel-janitors@lists.osdl.org
-https://lists.osdl.org/mailman/listinfo/kernel-janitors
diff --git a/a/content_digest b/N1/content_digest
index 8dedc2f..db9e273 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -1,7 +1,7 @@
  "ref\06b4e42d10609202311t47038692x5627f51d69f28209@mail.gmail.com\0"
  "From\0Nishanth Aravamudan <nacc@us.ibm.com>\0"
  "Subject\0Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]\0"
- "Date\0Thu, 21 Sep 2006 07:20:17 +0000\0"
+ "Date\0Thu, 21 Sep 2006 00:20:17 -0700\0"
  "To\0Om Narasimhan <om.turyx@gmail.com>\0"
  "Cc\0linux-kernel@vger.kernel.org"
  " kernel-janitors@lists.osdl.org\0"
@@ -43,7 +43,7 @@
  ">  \t\t\tif (iocommand.buf_size > 0) {\n"
  "> -\t\t\t\tbuff = kmalloc(iocommand.buf_size, GFP_KERNEL);\n"
  "> +\t\t\t\tbuff = kzalloc(iocommand.buf_size, GFP_KERNEL);\n"
- ">  \t\t\t\tif (buff = NULL)\n"
+ ">  \t\t\t\tif (buff == NULL)\n"
  ">  \t\t\t\t\treturn -EFAULT;\n"
  ">  \t\t\t}\n"
  "> @@ -911,8 +911,6 @@ #endif\n"
@@ -53,11 +53,11 @@
  "> -\t\t\t} else {\n"
  "> -\t\t\t\tmemset(buff, 0, iocommand.buf_size);\n"
  ">  \t\t\t}\n"
- ">  \t\t\tif ((c = cmd_alloc(host, 0)) = NULL) {\n"
+ ">  \t\t\tif ((c = cmd_alloc(host, 0)) == NULL) {\n"
  ">  \t\t\t\tkfree(buff);\n"
  "\n"
  "This changes performance potentially, no? The memset before was\n"
- "conditional upon (iocommand.Request.Type.Direction = XFER_WRITE) and\n"
+ "conditional upon (iocommand.Request.Type.Direction == XFER_WRITE) and\n"
  "now the memory will always be zero'd.\n"
  "\n"
  "> diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c\n"
@@ -107,10 +107,6 @@
  "\n"
  "-- \n"
  "Nishanth Aravamudan <nacc@us.ibm.com>\n"
- "IBM Linux Technology Center\n"
- "_______________________________________________\n"
- "Kernel-janitors mailing list\n"
- "Kernel-janitors@lists.osdl.org\n"
- https://lists.osdl.org/mailman/listinfo/kernel-janitors
+ IBM Linux Technology Center
 
-fcf4dbc18883a78570ed9b814014d82262420f05b1848c9d220795fc20444e50
+7024ef022d9cb2bc7d1eeb2aaa9b3d1d9d0ee1ad4c184bdbbbe414b0524e138e

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.