[lm-sensors] TODO: unchecked return codes from

[lm-sensors] TODO: unchecked return codes from

[Mark M. Hoffman]

Hi:

Updated list inline...

* Jim Cromie <jim.cromie at gmail.com> [2006-08-27 11:06:12 -0600]:
> Here is a quick status summary for drivers/hwmon:
> 
> Done by Mark M. Hoffman:
>  o asb100
>  o lm75
   o lm77
>  o lm78
   o lm80
   o lm85
   o lm87
   o lm92
>  o smsc47b397
>  o w83627hf
> 
> Done by Jim Cromie:
>  o pc87360
> 
> Will be done by David Hubbard:
>  o w83627ehf
> 
> Will be done by me: (Jean)
>  o f71805f
>  o it87
>  o lm63
>  o lm83
>  o lm90
> 
> This leaves the following list:
>  o abituguru
>  o adm1021
>  o adm1025
>  o adm1026
>  o adm1031
>  o adm9240
>  o atxp1
>  o ds1621
>  o fscher
>  o fscpos
>  o gl518sm
>  o gl520sm
>  o max1619
>  o sis5595
>  o smsc47m1
>  o smsc47m192
>  o via686a
>  o vt8231
>  o w83781d
>  o w83791d
>  o w83792d
>  o w83l785ts

-- 
Mark M. Hoffman
mhoffman at lightlink.com

[lm-sensors] TODO: unchecked return codes from

[Mark M. Hoffman]

Hello again; updated list inline...

> * Jim Cromie <jim.cromie at gmail.com> [2006-08-27 11:06:12 -0600]:
> > Here is a quick status summary for drivers/hwmon:
> > 
> > Done by Mark M. Hoffman:
     o adm1021
     o adm1025
     o adm1026
     o adm1031
     o adm9240
> >  o asb100
> >  o lm75
>    o lm77
> >  o lm78
>    o lm80
>    o lm85
>    o lm87
>    o lm92
> >  o smsc47b397
> >  o w83627hf
> > 
> > Done by Jim Cromie:
> >  o pc87360
> > 
> > Will be done by David Hubbard:
> >  o w83627ehf
> > 
> > Will be done by me: (Jean)
> >  o f71805f
> >  o it87
> >  o lm63
> >  o lm83
> >  o lm90
> > 
> > This leaves the following list:
> >  o abituguru
> >  o atxp1
> >  o ds1621
> >  o fscher
> >  o fscpos
> >  o gl518sm
> >  o gl520sm
> >  o max1619
> >  o sis5595
> >  o smsc47m1
> >  o smsc47m192
> >  o via686a
> >  o vt8231
> >  o w83781d
> >  o w83791d
> >  o w83792d
> >  o w83l785ts

Regards,

-- 
Mark "hope springs eternal" Hoffman
mhoffman at lightlink.com

[lm-sensors] TODO: unchecked return codes from

[Jean Delvare]

My turn :)

> > * Jim Cromie <jim.cromie at gmail.com> [2006-08-27 11:06:12 -0600]:
> > > Here is a quick status summary for drivers/hwmon:
> > > 
> > > Done by Mark M. Hoffman:
>      o adm1021
>      o adm1025
>      o adm1026
>      o adm1031
>      o adm9240
> > >  o asb100
> > >  o lm75
> >    o lm77
> > >  o lm78
> >    o lm80
> >    o lm85
> >    o lm87
> >    o lm92
> > >  o smsc47b397
> > >  o w83627hf
> > > 
> > > Done by Jim Cromie:
> > >  o pc87360
> > > 
> > > Will be done by David Hubbard:
> > >  o w83627ehf
> > > 
      Done by Jean Delvare:
       o f71805f
       o lm63
       o lm83
       o lm90

> > > Will be done by me: (Jean)
> > >  o it87
> > > 
> > > This leaves the following list:
> > >  o abituguru
> > >  o atxp1
> > >  o ds1621
> > >  o fscher
> > >  o fscpos
> > >  o gl518sm
> > >  o gl520sm
> > >  o max1619
> > >  o sis5595
> > >  o smsc47m1
> > >  o smsc47m192
> > >  o via686a
> > >  o vt8231
> > >  o w83781d
> > >  o w83791d
> > >  o w83792d
> > >  o w83l785ts

-- 
Jean Delvare

[lm-sensors] TODO: unchecked return codes from

[Jean Delvare]

Restarting the list from scratch for clarity:

Done by Mark M. Hoffman:
 o adm1021
 o adm1025
 o adm1026
 o adm1031
 o adm9240
 o asb100
 o lm75
 o lm77
 o lm78
 o lm80
 o lm85
 o lm87
 o lm92
 o smsc47b397
 o w83627hf

Done by Jim Cromie:
 o pc87360

Done by David Hubbard:
 o w83627ehf

Done by Jean Delvare:
 o f71805f
 o fscher
 o fscpos
 o gl518sm
 o gl520sm
 o it87
 o lm63
 o lm83
 o lm90

This leaves the following list:
 o abituguru
 o atxp1
 o ds1621
 o max1619
 o sis5595
 o smsc47m1
 o smsc47m192
 o via686a
 o vt8231
 o w83781d
 o w83791d
 o w83792d
 o w83l785ts

I'd like to remind everyone that this is an easy task, just look at the
patches submitted by either Mark of me, and do the same. So if you are
using one of the remaining drivers, please consider converting it and
sending the patch back to us.

Thanks,
-- 
Jean Delvare

[lm-sensors] TODO: unchecked return codes from

[Jim Cromie]

Jean Delvare wrote:
> Restarting the list from scratch for clarity:
>
> Done by Mark M. Hoffman:
>  o adm1021
>  o adm1025
>  o adm1026
>  o adm1031
>  o adm9240
>  o asb100
>  o lm75
>  o lm77
>  o lm78
>  o lm80
>  o lm85
>  o lm87
>  o lm92
>  o smsc47b397
>  o w83627hf
>
> Done by Jim Cromie:
>  o pc87360
>
> Done by David Hubbard:
>  o w83627ehf
>
> Done by Jean Delvare:
>  o f71805f
>  o fscher
>  o fscpos
>  o gl518sm
>  o gl520sm
>  o it87
>  o lm63
>  o lm83
>  o lm90
>
> This leaves the following list:
>  o abituguru
>  o atxp1
>  o ds1621
>  o max1619
>  o sis5595
>  o smsc47m1
>  o smsc47m192
>  o via686a
>  o vt8231
>  o w83781d
>  o w83791d
>  o w83792d
>  o w83l785ts
>
> I'd like to remind everyone that this is an easy task, just look at the
> patches submitted by either Mark of me, and do the same. So if you are
> using one of the remaining drivers, please consider converting it and
> sending the patch back to us.
>
> Thanks,
>   

heres patch for w83781d, compile-tested only.
hopefully you can find someone to test it.

---

replace many calls to device_create_file by adding them to a sysfs_group.
check return status from remaining calls to device_create_file(), which are
still needed for device-model dependent attr-files.

Signed-off-by:  Jim Cromie <jim.cromie at gmail.com>

---
 w83781d.c |  196 
+++++++++++++++++++++++++++++++++++++-------------------------
 1 files changed, 117 insertions(+), 79 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hwmon-unchecked-return-status-fixes-w83781d.patch
Type: text/x-patch
Size: 10015 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060907/d962e076/attachment.bin 

[lm-sensors] TODO: unchecked return codes from

[Jean Delvare]

Hi all,

> Restarting the list from scratch for clarity:
> 
> Done by Mark M. Hoffman:
>  o adm1021
>  o adm1025
>  o adm1026
>  o adm1031
>  o adm9240
>  o asb100
>  o lm75
>  o lm77
>  o lm78
>  o lm80
>  o lm85
>  o lm87
>  o lm92
>  o smsc47b397
>  o w83627hf
> 
> Done by Jim Cromie:
>  o pc87360
> 
> Done by David Hubbard:
>  o w83627ehf
> 
> Done by Jean Delvare:
>  o f71805f
>  o fscher
>  o fscpos
>  o gl518sm
>  o gl520sm
>  o it87
>  o lm63
>  o lm83
>  o lm90
> 
> This leaves the following list:
>  o abituguru
>  o atxp1
>  o ds1621
>  o max1619
>  o sis5595
>  o smsc47m1
>  o smsc47m192
>  o via686a
>  o vt8231
>  o w83781d
>  o w83791d
>  o w83792d
>  o w83l785ts
> 
> I'd like to remind everyone that this is an easy task, just look at the
> patches submitted by either Mark of me, and do the same. So if you are
> using one of the remaining drivers, please consider converting it and
> sending the patch back to us.

I'd appreciate if at least the drivers which have a dedicated
maintainer were fixed by said maintainers. This means:
 * Hand de Goede for the abituguru driver
 * Roger Lucas for the vt8231 driver
 * Charles Spirakis for the w83791d driver
I'd like to submit all these fixes in time for 2.6.19, which means the
patches must be ready by the end of the week. Can you guys take a look
at how we fixed the other drivers:
 http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017503.html
 (for example)
and submit patches for your respective drivers? Thanks.

-- 
Jean Delvare

[lm-sensors] TODO: unchecked return codes from

[Charles Spirakis]

I'll try to get to this over the weekend. Will that be too late?

-- charles


On 9/21/06, Jean Delvare <khali at linux-fr.org> wrote:
> Hi all,
>
> > Restarting the list from scratch for clarity:
> >
> > Done by Mark M. Hoffman:
> >  o adm1021
> >  o adm1025
> >  o adm1026
> >  o adm1031
> >  o adm9240
> >  o asb100
> >  o lm75
> >  o lm77
> >  o lm78
> >  o lm80
> >  o lm85
> >  o lm87
> >  o lm92
> >  o smsc47b397
> >  o w83627hf
> >
> > Done by Jim Cromie:
> >  o pc87360
> >
> > Done by David Hubbard:
> >  o w83627ehf
> >
> > Done by Jean Delvare:
> >  o f71805f
> >  o fscher
> >  o fscpos
> >  o gl518sm
> >  o gl520sm
> >  o it87
> >  o lm63
> >  o lm83
> >  o lm90
> >
> > This leaves the following list:
> >  o abituguru
> >  o atxp1
> >  o ds1621
> >  o max1619
> >  o sis5595
> >  o smsc47m1
> >  o smsc47m192
> >  o via686a
> >  o vt8231
> >  o w83781d
> >  o w83791d
> >  o w83792d
> >  o w83l785ts
> >
> > I'd like to remind everyone that this is an easy task, just look at the
> > patches submitted by either Mark of me, and do the same. So if you are
> > using one of the remaining drivers, please consider converting it and
> > sending the patch back to us.
>
> I'd appreciate if at least the drivers which have a dedicated
> maintainer were fixed by said maintainers. This means:
>  * Hand de Goede for the abituguru driver
>  * Roger Lucas for the vt8231 driver
>  * Charles Spirakis for the w83791d driver
> I'd like to submit all these fixes in time for 2.6.19, which means the
> patches must be ready by the end of the week. Can you guys take a look
> at how we fixed the other drivers:
>  http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017503.html
>  (for example)
> and submit patches for your respective drivers? Thanks.
>
> --
> Jean Delvare
>

[lm-sensors] TODO: unchecked return codes from

[Jean Delvare]

Hi Charles,

> I'll try to get to this over the weekend. Will that be too late?

My plan is to send the last batch of hwmon patches for 2.6.19 to Greg
KH on next Sunday (September 24th). If you provide your patch before
then, it'll be part of that batch. If not, no big deal, there are always
some bugfix patches coming after the big merge, and such a patch would
fit in there.

Thanks,
-- 
Jean Delvare

[lm-sensors] TODO: unchecked return codes from

[Jean Delvare]

Updating the list:

> Done by Mark M. Hoffman:
>  o adm1021
>  o adm1025
>  o adm1026
>  o adm1031
>  o adm9240
>  o asb100
>  o lm75
>  o lm77
>  o lm78
>  o lm80
>  o lm85
>  o lm87
>  o lm92
>  o smsc47b397
>  o w83627hf
> 
> Done by Jim Cromie:
>  o pc87360

Almost done by Jim Cromie:
   o w83781d

> Done by David Hubbard:
>  o w83627ehf
> 
> Done by Jean Delvare:
   o atxp1
   o ds1621
>  o f71805f
>  o fscher
>  o fscpos
>  o gl518sm
>  o gl520sm
>  o it87
>  o lm63
>  o lm83
>  o lm90
   o max1619
   o sis5595
   o via686a

Done by Roger Lucas:
   o vt8231

Will be done by Charles Spirakis:
   o w83791d

> This leaves the following list:
>  o abituguru
>  o smsc47m1
>  o smsc47m192
>  o w83792d
>  o w83l785ts

-- 
Jean Delvare