From: Denis Vlasenko <vda.linux@googlemail.com>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: [PATCH 0/3] make mdelay, udelay and ssleep calls smaller
Date: Fri, 22 Sep 2006 10:03:53 +0200 [thread overview]
Message-ID: <200609221003.53235.vda.linux@googlemail.com> (raw)
Hello Andrew,
This version is basically unchanged except for rediff
against 2.6.18. I was running previous version for
several weeks on 2.6.17.x kernels.
Russell King was giving me some feedback. I think that
my reply satisfied him - I got no further comments:
On Wednesday 23 August 2006 10:39, Denis Vlasenko wrote:
>On Wednesday 23 August 2006 10:14, Russell King wrote:
>> Please keep a "const" version in ARM. Thanks.
>
> Why do you want to keep it?
> I mean, without it udelay(n) will become slower by the time
> needed for one extra multiply. So we will have maybe
> udelay(n) ==> udelay(n+0.1).
>
>> Since the multiply is pure overhead, it's better
>> to get rid of it.
>
>You do not need to optimize delay for speed. If you
>really want to, then you can do:
>
>#define udelay(n) do {} while(0)
>
>Makes sense? No it does not. That's what I'm trying to say.
>You WANT to pause for thousands of cycles. Why you are trying
>to shave off ~10 cycles at the very same time?
>
>Hope it makes things clearer.
On with patch explanation:
Currently, magic in include/linux/delay.h
inlines mdelay and ssleep, and various arches
do the same to udelay.
This is pointless. We are going to perform a delay of 1000+
CPU cycles anyway, no need to optimize away a few cycles.
This patchset converts magic calls to these inlines/macros
into pure and simple function calls, with no additional
math done or hidden arguments pushed to stack
at the callsite.
Reduces allyesconfig kernel by about 7 kb.
Signed-off-by: Denis Vlasenko <vda.linux@googlemail.com>
--
vda
next reply other threads:[~2006-09-22 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 8:03 Denis Vlasenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-22 15:08 [PATCH 0/3] make mdelay, udelay and ssleep calls smaller Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609221003.53235.vda.linux@googlemail.com \
--to=vda.linux@googlemail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.