From: Andy Whitcroft <apw@shadowen.org>
To: git@vger.kernel.org
Subject: [PATCH] perl bindings fix compilation errors
Date: Mon, 25 Sep 2006 11:03:20 +0100 [thread overview]
Message-ID: <20060925100319.GA1655@shadowen.org> (raw)
perl bindings: fix compilation errors
With the introduction of Makefile.PL to the perl bindings we no
longer seem to pass in either the definition of SHA1_HEADER or
GIT_VERSION. It seems we no longer pass over the BASIC_FLAGS into
the compilation.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
diff --git a/Makefile b/Makefile
index d705e06..d32f4c4 100644
--- a/Makefile
+++ b/Makefile
@@ -603,7 +603,7 @@ all: $(ALL_PROGRAMS) $(BUILT_INS) git$X
git-merge-recur$X
all: perl/Makefile
- $(MAKE) -C perl
+ $(MAKE) -C perl GIT_VERSION='$(GIT_VERSION)' BASIC_CFLAGS="$(BASIC_CFLAGS)"
$(MAKE) -C templates
strip: $(PROGRAMS) git$X
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index de73235..00fc779 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -5,6 +5,8 @@ sub MY::postamble {
instlibdir:
@echo '$(INSTALLSITELIB)'
+CCFLAGS += -DGIT_VERSION='"$(GIT_VERSION)"' $(BASIC_CFLAGS)
+
MAKE_FRAG
}
next reply other threads:[~2006-09-25 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 10:03 Andy Whitcroft [this message]
2006-09-25 10:25 ` [PATCH] perl bindings fix compilation errors Johannes Schindelin
2006-09-25 11:34 ` Andy Whitcroft
2006-09-25 11:38 ` Johannes Schindelin
2006-09-26 4:54 ` Junio C Hamano
2006-09-26 8:34 ` Johannes Schindelin
2006-09-27 2:40 ` Junio C Hamano
2006-09-27 9:42 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925100319.GA1655@shadowen.org \
--to=apw@shadowen.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.