From: Al Viro <viro@ftp.linux.org.uk>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: dougg@torque.net, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
Date: Mon, 25 Sep 2006 18:39:23 +0100 [thread overview]
Message-ID: <20060925173922.GL29920@ftp.linux.org.uk> (raw)
In-Reply-To: <20060925171634.69667.qmail@web31809.mail.mud.yahoo.com>
On Mon, Sep 25, 2006 at 10:16:34AM -0700, Luben Tuikov wrote:
> --- Douglas Gilbert <dougg@torque.net> wrote:
> > Al Viro wrote:
> > > To whoever had written that code:
> > >
> > > a) priority of >> is higher than that of &
> > > b) priority of typecast is higher than that of any binary operator
> > > c) learn the fscking C
> [...]
> > BTW Luben was pointing out that the call you patched
> > and the following call can be combined into a less
> > trouble prone asd_write_reg_dword() call.
>
> More than that -- I looked at the history of that
> file/line and the code as I had written it _never_ had
> that broken cast and shift mess.
Far more interesting question: where does the hardware expect to see the
upper 16 bits of that 32bit value? Which one it is - LmSEQ_INTEN_SAVE(lseq)
ori LmSEQ_INTEN_SAVE(lseq) + 2?
next prev parent reply other threads:[~2006-09-25 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 1:57 [PATCH] fix idiocy in asd_init_lseq_mdp() Al Viro
2006-09-25 6:52 ` Luben Tuikov
2006-09-25 6:54 ` Luben Tuikov
2006-09-25 14:47 ` Douglas Gilbert
2006-09-25 14:59 ` Al Viro
2006-09-25 17:16 ` Luben Tuikov
2006-09-25 17:39 ` Al Viro [this message]
2006-09-25 17:43 ` James Bottomley
2006-09-25 18:29 ` Mike Anderson
2006-09-25 19:14 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2006-09-25 19:56 Hammer, Jack
2006-09-25 19:56 ` Hammer, Jack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060925173922.GL29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.