All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org
Subject: [PATCH 3/4] ethtool: don't show sync queue's on skge/sky2
Date: Tue, 26 Sep 2006 13:10:00 -0700	[thread overview]
Message-ID: <20060926131000.08a67c89@freekitty> (raw)
In-Reply-To: <451AF4B1.2000208@pobox.com>

Remove printout of synchronous transmit queue info because
it is unused by the driver.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
---
 marvell.c |   22 +++++++++++-----------
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/marvell.c b/marvell.c
index 08fdbd9..373ebcf 100644
--- a/marvell.c
+++ b/marvell.c
@@ -174,12 +174,12 @@ int skge_dump_regs(struct ethtool_drvinf
 	printf("\nBus Management Unit\n");
 	printf("-------------------\n");
 	printf("CSR Receive Queue 1              0x%08X\n", r[24]);
-	printf("CSR Sync Queue 1                 0x%08X\n", r[26]);
+//	printf("CSR Sync Queue 1                 0x%08X\n", r[26]);
 	printf("CSR Async Queue 1                0x%08X\n", r[27]);
 	if (dual) {
 		printf("CSR Receive Queue 2              0x%08X\n", r[25]);
 		printf("CSR Async Queue 2                0x%08X\n", r[29]);
-		printf("CSR Sync Queue 2                 0x%08X\n", r[28]);
+//		printf("CSR Sync Queue 2                 0x%08X\n", r[28]);
 	}
 
 	dump_mac(regs->data);
@@ -190,11 +190,11 @@ int skge_dump_regs(struct ethtool_drvinf
 	dump_timer("Blink Source", regs->data +0x170);
 
 	dump_queue("Receive Queue 1", regs->data +0x400, 1);
-	dump_queue("Sync Transmit Queue 1", regs->data +0x600, 0);
+//	dump_queue("Sync Transmit Queue 1", regs->data +0x600, 0);
 	dump_queue("Async Transmit Queue 1", regs->data +0x680, 0);
 
 	dump_ram("Receive RAMbuffer 1", regs->data+0x800);
-	dump_ram("Sync Transmit RAMbuffer 1", regs->data+0xa00);
+//	dump_ram("Sync Transmit RAMbuffer 1", regs->data+0xa00);
 	dump_ram("Async Transmit RAMbuffer 1", regs->data+0xa80);
 
 	dump_fifo("Receive MAC FIFO 1", regs->data+0xc00);
@@ -204,10 +204,10 @@ int skge_dump_regs(struct ethtool_drvinf
 
 		dump_queue("Receive Queue 2", regs->data +0x480, 1);
 		dump_queue("Async Transmit Queue 2", regs->data +0x780, 0);
-		dump_queue("Sync Transmit Queue 2", regs->data +0x700, 0);
+//		dump_queue("Sync Transmit Queue 2", regs->data +0x700, 0);
 
 		dump_ram("Receive RAMbuffer 2", regs->data+0x880);
-		dump_ram("Sync Transmit RAMbuffer 2", regs->data+0xb00);
+//		dump_ram("Sync Transmit RAMbuffer 2", regs->data+0xb00);
 		dump_ram("Async Transmit RAMbuffer 21", regs->data+0xb80);
 
 		dump_fifo("Receive MAC FIFO 2", regs->data+0xc80);
@@ -282,14 +282,14 @@ int sky2_dump_regs(struct ethtool_drvinf
 	printf("\nBus Management Unit\n");
 	printf("-------------------\n");
 	printf("CSR Receive Queue 1              0x%08X\n", r[24]);
-	printf("CSR Sync Queue 1                 0x%08X\n", r[26]);
+//	printf("CSR Sync Queue 1                 0x%08X\n", r[26]);
 	printf("CSR Async Queue 1                0x%08X\n", r[27]);
 
 	dual = (regs->data[0x11e] & 2) != 0;
 	if (dual) {
 		printf("CSR Receive Queue 2              0x%08X\n", r[25]);
 		printf("CSR Async Queue 2                0x%08X\n", r[29]);
-		printf("CSR Sync Queue 2                 0x%08X\n", r[28]);
+//		printf("CSR Sync Queue 2                 0x%08X\n", r[28]);
 	}
 
 	dump_mac(regs->data);
@@ -324,17 +324,17 @@ int sky2_dump_regs(struct ethtool_drvinf
 	dump_timer("ISR", regs->data + 0xed0);
 
 	dump_queue2("Receive Queue 1", regs->data +0x400, 1);
-	dump_queue("Sync Transmit Queue 1", regs->data +0x600, 0);
+//	dump_queue("Sync Transmit Queue 1", regs->data +0x600, 0);
 	dump_queue2("Async Transmit Queue 1", regs->data +0x680, 0);
 
 
 	dump_ram("Receive RAMbuffer 1", regs->data+0x800);
-	dump_ram("Sync Transmit RAMbuffer 1", regs->data+0xa00);
+//	dump_ram("Sync Transmit RAMbuffer 1", regs->data+0xa00);
 	dump_ram("Async Transmit RAMbuffer 1", regs->data+0xa80);
 
 	if (dual) {
 		dump_ram("Receive RAMbuffer 2", regs->data+0x880);
-		dump_ram("Sync Transmit RAMbuffer 2", regs->data+0xb00);
+//		dump_ram("Sync Transmit RAMbuffer 2", regs->data+0xb00);
 		dump_ram("Async Transmit RAMbuffer 21", regs->data+0xb80);
 		dump_gmac("GMAC 2", regs->data + 0x3800);
 	}
-- 
1.4.1


  parent reply	other threads:[~2006-09-27 22:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-26 18:54 [PATCH] ethtool: add sky2 register dump Stephen Hemminger
2006-09-27 22:01 ` Jeff Garzik
2006-09-26 20:08   ` [PATCH 1/4] ethtool: move skge.c to marvell.c Stephen Hemminger
2006-09-27 23:03     ` Jeff Garzik
2006-09-26 20:09   ` [PATCH 2/4] ethtool: sky2 support Stephen Hemminger
2006-09-26 20:10   ` Stephen Hemminger [this message]
2006-09-27 23:03     ` [PATCH 3/4] ethtool: don't show sync queue's on skge/sky2 Jeff Garzik
2006-09-27 22:34       ` Stephen Hemminger
2006-09-27 23:19         ` Jeff Garzik
2006-09-26 20:10   ` [PATCH 4/4] ethtool: spelling fix Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060926131000.08a67c89@freekitty \
    --to=shemminger@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.