All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linux-kernel@vger.kernel.org, akpm@osdl.org
Cc: ebiederm@xmission.com, ak@suse.de, benh@kernel.crashing.org,
	greg@kroah.com, mingo@elte.hu, tglx@linutronix.de,
	tony.luck@intel.com
Subject: Re: + msi-refactor-and-move-the-msi-irq_chip-into-the-arch-code.patch added to -mm tree
Date: Wed, 27 Sep 2006 15:50:35 -0700 (PDT)	[thread overview]
Message-ID: <20060927.155035.74747595.davem@davemloft.net> (raw)
In-Reply-To: <200609272215.k8RMFbuH018967@shell0.pdx.osdl.net>

From: akpm@osdl.org
Date: Wed, 27 Sep 2006 15:15:37 -0700

> Subject: msi: refactor and move the msi irq_chip into the arch code
> From: "Eric W. Biederman" <ebiederm@xmission.com>
> 
> It turns out msi_ops was simply not enough to abstract the architecture
> specific details of msi.  So I have moved the resposibility of constructing
> the struct irq_chip to the architectures, and have two architecture specific
> functions arch_setup_msi_irq, and arch_teardown_msi_irq.
> 
> For simple architectures those functions can do all of the work.  For
> architectures with platform dependencies they can call into the appropriate
> platform code.
> 
> With this msi.c is finally free of assuming you have an apic, and this
> actually takes less code.
> 
> The helpers for the architecture specific code are declared in the linux/msi.h
> to keep them separate from the msi functions used by drivers in linux/pci.h
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Andi Kleen <ak@suse.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Greg KH <greg@kroah.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Andrew Morton <akpm@osdl.org>

Eric, thanks so much for doing this work.

Once this goes in I'll try to add support for MSI on sparc64
Niagara boxes.  I suppose the PowerPC folks can make use of
this as well.


       reply	other threads:[~2006-09-27 22:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200609272215.k8RMFbuH018967@shell0.pdx.osdl.net>
2006-09-27 22:50 ` David Miller [this message]
2006-09-27 23:09   ` + msi-refactor-and-move-the-msi-irq_chip-into-the-arch-code.patch added to -mm tree Benjamin Herrenschmidt
2006-09-28  5:50     ` Eric W. Biederman
2006-09-28  6:16       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060927.155035.74747595.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=ebiederm@xmission.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.