From: Jim Paris <jim@jtan.com>
To: Tejun Heo <htejun@gmail.com>
Cc: mail@philipp-wagner.com, linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] libata: lengthen interval between SRST set and clear
Date: Thu, 28 Sep 2006 02:23:57 -0400 [thread overview]
Message-ID: <20060928062357.GA12266@jim.sh> (raw)
In-Reply-To: <20060928051415.GG25800@htj.dyndns.org>
Hi Tejun,
> 20us isn't enough for some SATA controllers (sata_nv) ending up not
> sending the second FIS27 to clear SRST. This usually results in SRST
> timeout causing excessive delays during hotplug.
>
> This patch lengthens the delay from 20us to 1ms and also converts it
> to msleep() instead of busy wait.
Thanks for the patch. Unfortunately it doesn't seem to help on 2.6.18:
Unplug:
[ 190.559849] ata3: exception Emask 0x10 SAct 0x0 SErr 0x1810000 action 0x2 frozen
[ 191.274576] ata3: soft resetting port
[ 191.274580] ata3: SATA link down (SStatus 0 SControl 300)
[ 191.274585] ata3: failed to recover some devices, retrying in 5 secs
[ 196.276276] ata3: hard resetting port
[ 196.999941] ata3: SATA link down (SStatus 0 SControl 300)
[ 196.999947] ata3: failed to recover some devices, retrying in 5 secs
[ 202.001639] ata3: hard resetting port
[ 202.725303] ata3: SATA link down (SStatus 0 SControl 300)
[ 202.725309] ata3.00: disabled
[ 203.229080] ata3: EH complete
[ 203.229091] ata3.00: detaching (SCSI 2:0:0:0)
Replug:
[ 222.501022] ata3: exception Emask 0x10 SAct 0x0 SErr 0x150000 action 0x2 frozen
[ 230.220666] ata3: port is slow to respond, please be patient
[ 253.226040] ata3: port failed to respond (30 secs)
[ 253.226090] ata3: soft resetting port
[ 260.398768] ata3: port is slow to respond, please be patient
[ 283.404138] ata3: port failed to respond (30 secs)
[ 283.404195] ata3: SATA link up 1.5 Gbps (SStatus 113 SControl 300)
[ 283.404203] ata3: EH complete
and the disk never comes back. This is just like my earlier log from
vanilla 2.6.18 (except SErr differs by 0x100000).
-jim
next prev parent reply other threads:[~2006-09-28 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 8:20 sata_nv hotplug in 2.6.18 Jim Paris
2006-09-28 5:14 ` [PATCH] libata: lengthen interval between SRST set and clear Tejun Heo
2006-09-28 6:23 ` Jim Paris [this message]
2006-09-28 8:04 ` Tejun Heo
2006-09-28 8:34 ` Jim Paris
2006-09-28 8:49 ` [PATCH] sata_nv: SRST sometimes fails after hotplug, use HRST_TO_RESUME Tejun Heo
2006-11-01 5:14 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-09-28 8:52 [PATCH] libata: lengthen interval between SRST set and clear justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928062357.GA12266@jim.sh \
--to=jim@jtan.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mail@philipp-wagner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.