From: Andi Kleen <ak@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Kyle McMartin <kyle@parisc-linux.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
akpm@osdl.org, jbeulich@novell.com
Subject: Re: [BUG] Oops on boot (probably ACPI related)
Date: Thu, 28 Sep 2006 09:49:06 +0200 [thread overview]
Message-ID: <200609280949.06676.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0609271436310.3952@g5.osdl.org>
On Wednesday 27 September 2006 23:38, Linus Torvalds wrote:
>
> On Wed, 27 Sep 2006, Andi Kleen wrote:
> >
> > It doesn't matter much because these days this stuff is all out of lined
> > anyways and in a single function. And the dynamic branch predictor
> > in all modern CPUs will usually cache the decision (unlocked) there.
>
> Ahh, good point. Once there's only one copy, the branch predictor will get
> it right (and the code size won't much matter)
As a postscript I (unintentionally) bended the truth on that one actually
yesterday. Sorry for that. Semaphores are still inline, unlike spinlocks.
However if the spinlocks are out of line I see no reason to keep semaphores
inline either, so perhaps it would be better to just move them. Then my
argument above would actually work :)
For some reason the unwinder also still seems to get stuck on it :/
-Andi
next prev parent reply other threads:[~2006-09-28 7:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 12:24 [BUG] Oops on boot (probably ACPI related) Rolf Eike Beer
2006-09-27 17:56 ` Markus Dahms
2006-09-27 17:56 ` Markus Dahms
2006-09-27 18:40 ` Kyle McMartin
2006-09-27 19:38 ` Andi Kleen
2006-09-27 20:21 ` Linus Torvalds
2006-09-27 20:35 ` Linus Torvalds
2006-09-27 20:50 ` Andi Kleen
2006-09-27 21:38 ` Linus Torvalds
2006-09-28 7:49 ` Andi Kleen [this message]
2006-09-27 20:58 ` Kyle McMartin
2006-09-27 22:32 ` Andrew Morton
2006-09-27 19:38 ` Andi Kleen
2006-09-28 7:04 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609280949.06676.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jbeulich@novell.com \
--cc=kyle@parisc-linux.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.