From: Andi Drebes <lists-receive@programmierforen.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] string initialization in ForeRunnerHE driver
Date: Sun, 01 Oct 2006 11:14:20 +0000 [thread overview]
Message-ID: <200610011314.20555.lists-receive@programmierforen.de> (raw)
I had a look at http://www.kerneljanitors.org/TODO
Jeff Garzik writes that in most cases a string initialization like char
foo[] = "blah"; is preferred to an initialization like char *foo = "blah";
So I grep'd around the kernel sources and found an initialization in the
latter style in drivers/atm/he.c. This is my first patch ever sent to the
kj-mailing-list. I hope everything is fine with the patch-format and so on.
If not, please let me know...
I don't know if this patch is really needed. However, here it is (tested by
compilation):
Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index f2511b4..f16a1ce 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -101,7 +101,7 @@ #endif /* HE_DEBUG */
/* version definition */
-static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
+static char version[] = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
/* declarations */
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2006-10-01 11:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610011314.20555.lists-receive@programmierforen.de \
--to=lists-receive@programmierforen.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.