From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: chas@cmf.nrl.navy.mil, Netdev List <netdev@vger.kernel.org>
Subject: Re: ATM bug found
Date: Sun, 1 Oct 2006 07:58:29 -0700 [thread overview]
Message-ID: <20061001145829.GA83074@gaz.sfgoth.com> (raw)
In-Reply-To: <451FC182.6000502@garzik.org>
(trimmed cc:'s since, IMO, isn't really all that general interest)
Jeff Garzik wrote:
> drivers/atm/zatm.c: In function ?zatm_open?:
> drivers/atm/zatm.c:919: warning: ?pcr? may be used uninitialized in this
> function
Yeah, looks like a bug. Not very high-impact because:
1. it only results in garbled data in vcc->qos.txtp which doesn't
really mean much for UBR vcc's anyway
2. zatm is a more-obscure-than-obscure piece of hardware. I'm sure
3c501.c has more users these days :-)
The fix is for alloc_shaper() should really do "*pcr = ATM_MAX_PCR" in
the "if (ubr)" stanza. Chas, want to submit that in the next batch
of patches?
-Mitch
next prev parent reply other threads:[~2006-10-01 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 13:24 ATM bug found Jeff Garzik
2006-10-01 14:58 ` Mitchell Blank Jr [this message]
2006-10-01 15:22 ` chas williams - CONTRACTOR
2006-10-01 15:14 ` chas williams - CONTRACTOR
2006-10-01 15:38 ` Mitchell Blank Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061001145829.GA83074@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.