From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>,
Netdev List <netdev@vger.kernel.org>
Subject: Re: ATM firestream bug
Date: Sun, 1 Oct 2006 08:10:41 -0700 [thread overview]
Message-ID: <20061001151041.GC83074@gaz.sfgoth.com> (raw)
In-Reply-To: <451FD494.1090804@garzik.org>
Jeff Garzik wrote:
> 1) not safe on 64-bit
Almost certainly correct. Probably never will be -- IIRC this SAR was
mainly used in embedded apps. I don't know if any commercially-available
PCI cards were ever made with it. I could be wrong though, it's been awhile
since I was up on the ATM industry.
> 2) variable 'tmc0' is indeed potentially used uninit'd, in particular if
> make_rate() returns an error (use occurs before error check).
Exact same error as the one you spotted in ambassador.c -- make_rate()'s
error is not checked at all. It should be.
-Mitch
next prev parent reply other threads:[~2006-10-01 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 14:45 ATM firestream bug Jeff Garzik
2006-10-01 15:10 ` Mitchell Blank Jr [this message]
2006-10-01 16:56 ` chas williams - CONTRACTOR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061001151041.GC83074@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.