From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Cc: Alan Stern <stern@rowland.harvard.edu>, Paul Jackson <pj@sgi.com>,
Greg KH <greg@kroah.com>
Subject: [PATCH] usb hubc build fix.patch prefix
Date: Sun, 01 Oct 2006 19:37:20 -0700 [thread overview]
Message-ID: <20061002023720.9780.85391.sendpatchset@v0> (raw)
From: Paul Jackson <pj@sgi.com>
The patch series 2.6.18-mm2-broken-out does not apply to 2.6.18,
for me anyway.
The 'quilt push' of this series fails with:
Applying patch usb-hubc-build-fix.patch
patching file drivers/usb/core/hub.c
Hunk #1 FAILED at 1831.
Hunk #2 succeeded at 1904 (offset -2 lines).
Hunk #3 FAILED at 1946.
2 out of 3 hunks FAILED -- rejects in file drivers/usb/core/hub.c
Patch usb-hubc-build-fix.patch does not apply (enforce with -f)
If I apply the following patch *just before* the failing
usb-hubc-build-fix.patch, everything applies cleanly from there on
down the patch set.
I don't know what's right here. I'm just blindly pushing code.
But it seems obvious to me that the 2.6.18-mm2 broken-out patch set
is borked:
The first patch in the series: origin.patch, definitely places these
two hub_* defines just before the usb_resume_root_hub() routine.
But then the patch usb-hubc-build-fix.patch clearly expects to find
those two hub_* defines just before the hub_suspend() routine.
Signed-off-by: Paul Jackson <pj@sgi.com>
---
drivers/usb/core/hub.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- 2.6.18-mm2.orig/drivers/usb/core/hub.c 2006-10-01 17:52:53.000000000 -0700
+++ 2.6.18-mm2/drivers/usb/core/hub.c 2006-10-01 18:26:17.000000000 -0700
@@ -1862,6 +1862,8 @@ static inline int remote_wakeup(struct u
return 0;
}
+#define hub_suspend NULL
+#define hub_resume NULL
#endif
static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
@@ -1946,8 +1948,6 @@ static inline int remote_wakeup(struct u
return 0;
}
-#define hub_suspend NULL
-#define hub_resume NULL
#endif
void usb_resume_root_hub(struct usb_device *hdev)
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next reply other threads:[~2006-10-02 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-02 2:37 Paul Jackson [this message]
2006-10-02 14:15 ` [PATCH] usb hubc build fix.patch prefix Alan Stern
2006-10-02 16:27 ` Paul Jackson
2006-10-02 18:12 ` Andrew Morton
2006-10-02 18:28 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002023720.9780.85391.sendpatchset@v0 \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.