From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: [PATCH 3 of 3] nfsd4: fslocs: remove spurious NULL check Date: Mon, 2 Oct 2006 14:26:41 -0400 Message-ID: <20061002182641.GE8084@fieldses.org> References: <20060929130518.23919.patches@notabene> <1060929030913.24108@suse.de> <20060928234540.fd74f1e1.akpm@osdl.org> <20061002182327.GB8084@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: NeilBrown , nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1GUSV3-0006Rp-Mn for nfs@lists.sourceforge.net; Mon, 02 Oct 2006 11:26:45 -0700 Received: from mail.fieldses.org ([66.93.2.214] helo=pickle.fieldses.org) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1GUSV3-0004EV-CG for nfs@lists.sourceforge.net; Mon, 02 Oct 2006 11:26:46 -0700 To: Andrew Morton In-Reply-To: <20061002182327.GB8084@fieldses.org> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net It's obvious that the two callers of this function never call it with NULL. Signed-off-by: J. Bruce Fields --- fs/nfsd/export.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index ee7b03a..4a11092 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -323,9 +323,6 @@ static void nfsd4_fslocs_free(struct nfs { int i; - if (fsloc == NULL) - return; - for (i = 0; i < fsloc->locations_count; i++) { kfree(fsloc->locations[i].path); kfree(fsloc->locations[i].hosts); -- 1.4.2.g55c3 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965275AbWJBS0q (ORCPT ); Mon, 2 Oct 2006 14:26:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965261AbWJBS0q (ORCPT ); Mon, 2 Oct 2006 14:26:46 -0400 Received: from mail.fieldses.org ([66.93.2.214]:3200 "EHLO pickle.fieldses.org") by vger.kernel.org with ESMTP id S965275AbWJBS0o (ORCPT ); Mon, 2 Oct 2006 14:26:44 -0400 Date: Mon, 2 Oct 2006 14:26:41 -0400 To: Andrew Morton Cc: NeilBrown , nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH 3 of 3] nfsd4: fslocs: remove spurious NULL check Message-ID: <20061002182641.GE8084@fieldses.org> References: <20060929130518.23919.patches@notabene> <1060929030913.24108@suse.de> <20060928234540.fd74f1e1.akpm@osdl.org> <20061002182327.GB8084@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061002182327.GB8084@fieldses.org> User-Agent: Mutt/1.5.13 (2006-08-11) From: "J. Bruce Fields" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org It's obvious that the two callers of this function never call it with NULL. Signed-off-by: J. Bruce Fields --- fs/nfsd/export.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index ee7b03a..4a11092 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -323,9 +323,6 @@ static void nfsd4_fslocs_free(struct nfs { int i; - if (fsloc == NULL) - return; - for (i = 0; i < fsloc->locations_count; i++) { kfree(fsloc->locations[i].path); kfree(fsloc->locations[i].hosts); -- 1.4.2.g55c3