* [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 1:22 ` Adrian Bunk
0 siblings, 0 replies; 37+ messages in thread
From: Adrian Bunk @ 2006-10-03 1:22 UTC (permalink / raw)
To: Judith Lebzelter; +Cc: linux-kernel, linuxppc-dev
On Tue, Oct 03, 2006 at 01:44:28AM +0200, Adrian Bunk wrote:
> On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
>
> > Hello:
>
> Hi Judith,
>
> > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > 'allmodconfig' is failing. The warnings/errors below appear in
> > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
>
> known for ages - the drivers need fixing.
>
> You might want to convince Andrew accepting my patch to make
> virt_to_bus/bus_to_virt give compile warnings on i386 for making
> people more aware of this problem...
>...
In case anyone is interested, the patch is below.
cu
Adrian
<-- snip -->
virt_to_bus/bus_to_virt are long deprecated, mark them as __deprecated
on i386.
Without such warnings people will never update their code and fix
the errors in PPC64 builds.
And yes, some of the drivers affected are maintained.
This also catches accidential additions of users for these functions
like a usage of bus_to_virt() in the infiniband code that was added in
2.6.17-rc1 (already removed).
This patch increases the number of warnings shown during builds, but it
seems worth including it at least in -mm for making people aware of this
issue.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 7 Jul 2006
- 26 Jun 2006
- 27 Apr 2006
- 19 Apr 2006
- 6 Jan 2006
- 13 Dec 2005
- 23 Nov 2005
- 18 Nov 2005
- 12 Nov 2005
--- linux-2.6.14-mm2-full/include/asm-i386/io.h.old 2005-11-12 01:44:38.000000000 +0100
+++ linux-2.6.14-mm2-full/include/asm-i386/io.h 2005-11-12 01:45:58.000000000 +0100
@@ -144,8 +144,14 @@
*
* Allow them on x86 for legacy drivers, though.
*/
-#define virt_to_bus virt_to_phys
-#define bus_to_virt phys_to_virt
+static inline unsigned long __deprecated virt_to_bus(volatile void * address)
+{
+ return __pa(address);
+}
+static inline void * __deprecated bus_to_virt(unsigned long address)
+{
+ return __va(address);
+}
/*
* readX/writeX() are used to access memory mapped devices. On some
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 1:22 ` Adrian Bunk
@ 2006-10-03 1:48 ` Nicholas Miell
-1 siblings, 0 replies; 37+ messages in thread
From: Nicholas Miell @ 2006-10-03 1:48 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, Judith Lebzelter, linux-kernel
On Tue, 2006-10-03 at 03:22 +0200, Adrian Bunk wrote:
> On Tue, Oct 03, 2006 at 01:44:28AM +0200, Adrian Bunk wrote:
> > On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
> >
> > > Hello:
> >
> > Hi Judith,
> >
> > > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > > 'allmodconfig' is failing. The warnings/errors below appear in
> > > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
> >
> > known for ages - the drivers need fixing.
> >
> > You might want to convince Andrew accepting my patch to make
> > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > people more aware of this problem...
> >...
>
> In case anyone is interested, the patch is below.
>
> cu
> Adrian
>
Won't this also cause warnings for valid arch-specific usage (i.e. in
linux/arch/{i386,x86_64})?
--
Nicholas Miell <nmiell@comcast.net>
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 1:48 ` Nicholas Miell
0 siblings, 0 replies; 37+ messages in thread
From: Nicholas Miell @ 2006-10-03 1:48 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Judith Lebzelter, linux-kernel, linuxppc-dev
On Tue, 2006-10-03 at 03:22 +0200, Adrian Bunk wrote:
> On Tue, Oct 03, 2006 at 01:44:28AM +0200, Adrian Bunk wrote:
> > On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
> >
> > > Hello:
> >
> > Hi Judith,
> >
> > > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > > 'allmodconfig' is failing. The warnings/errors below appear in
> > > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
> >
> > known for ages - the drivers need fixing.
> >
> > You might want to convince Andrew accepting my patch to make
> > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > people more aware of this problem...
> >...
>
> In case anyone is interested, the patch is below.
>
> cu
> Adrian
>
Won't this also cause warnings for valid arch-specific usage (i.e. in
linux/arch/{i386,x86_64})?
--
Nicholas Miell <nmiell@comcast.net>
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 1:48 ` Nicholas Miell
@ 2006-10-03 1:58 ` Adrian Bunk
-1 siblings, 0 replies; 37+ messages in thread
From: Adrian Bunk @ 2006-10-03 1:58 UTC (permalink / raw)
To: Nicholas Miell; +Cc: linuxppc-dev, Judith Lebzelter, linux-kernel
On Mon, Oct 02, 2006 at 06:48:11PM -0700, Nicholas Miell wrote:
> On Tue, 2006-10-03 at 03:22 +0200, Adrian Bunk wrote:
> > On Tue, Oct 03, 2006 at 01:44:28AM +0200, Adrian Bunk wrote:
> > > On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
> > >
> > > > Hello:
> > >
> > > Hi Judith,
> > >
> > > > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > > > 'allmodconfig' is failing. The warnings/errors below appear in
> > > > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
> > >
> > > known for ages - the drivers need fixing.
> > >
> > > You might want to convince Andrew accepting my patch to make
> > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > people more aware of this problem...
> > >...
> >
> > In case anyone is interested, the patch is below.
> >
> > cu
> > Adrian
> >
>
> Won't this also cause warnings for valid arch-specific usage (i.e. in
> linux/arch/{i386,x86_64})?
They aren't used under linux/arch/i386/ and my patch doesn't change x86_64.
> Nicholas Miell <nmiell@comcast.net>
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 1:58 ` Adrian Bunk
0 siblings, 0 replies; 37+ messages in thread
From: Adrian Bunk @ 2006-10-03 1:58 UTC (permalink / raw)
To: Nicholas Miell; +Cc: Judith Lebzelter, linux-kernel, linuxppc-dev
On Mon, Oct 02, 2006 at 06:48:11PM -0700, Nicholas Miell wrote:
> On Tue, 2006-10-03 at 03:22 +0200, Adrian Bunk wrote:
> > On Tue, Oct 03, 2006 at 01:44:28AM +0200, Adrian Bunk wrote:
> > > On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
> > >
> > > > Hello:
> > >
> > > Hi Judith,
> > >
> > > > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > > > 'allmodconfig' is failing. The warnings/errors below appear in
> > > > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
> > >
> > > known for ages - the drivers need fixing.
> > >
> > > You might want to convince Andrew accepting my patch to make
> > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > people more aware of this problem...
> > >...
> >
> > In case anyone is interested, the patch is below.
> >
> > cu
> > Adrian
> >
>
> Won't this also cause warnings for valid arch-specific usage (i.e. in
> linux/arch/{i386,x86_64})?
They aren't used under linux/arch/i386/ and my patch doesn't change x86_64.
> Nicholas Miell <nmiell@comcast.net>
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 1:58 ` Adrian Bunk
@ 2006-10-03 2:55 ` Nicholas Miell
-1 siblings, 0 replies; 37+ messages in thread
From: Nicholas Miell @ 2006-10-03 2:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, Judith Lebzelter, linux-kernel
On Tue, 2006-10-03 at 03:58 +0200, Adrian Bunk wrote:
> On Mon, Oct 02, 2006 at 06:48:11PM -0700, Nicholas Miell wrote:
> > On Tue, 2006-10-03 at 03:22 +0200, Adrian Bunk wrote:
> > > On Tue, Oct 03, 2006 at 01:44:28AM +0200, Adrian Bunk wrote:
> > > > On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
> > > >
> > > > > Hello:
> > > >
> > > > Hi Judith,
> > > >
> > > > > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > > > > 'allmodconfig' is failing. The warnings/errors below appear in
> > > > > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
> > > >
> > > > known for ages - the drivers need fixing.
> > > >
> > > > You might want to convince Andrew accepting my patch to make
> > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > people more aware of this problem...
> > > >...
> > >
> > > In case anyone is interested, the patch is below.
> > >
> > > cu
> > > Adrian
> > >
> >
> > Won't this also cause warnings for valid arch-specific usage (i.e. in
> > linux/arch/{i386,x86_64})?
>
> They aren't used under linux/arch/i386/ and my patch doesn't change x86_64.
Sorry, for some reason I thought isa_bus_to_virt and isa_virt_to_bus
were defined in terms of virt_to_bus/bus_to_virt instead of
virt_to_phys/phys_to_virt.
--
Nicholas Miell <nmiell@comcast.net>
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 2:55 ` Nicholas Miell
0 siblings, 0 replies; 37+ messages in thread
From: Nicholas Miell @ 2006-10-03 2:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Judith Lebzelter, linux-kernel, linuxppc-dev
On Tue, 2006-10-03 at 03:58 +0200, Adrian Bunk wrote:
> On Mon, Oct 02, 2006 at 06:48:11PM -0700, Nicholas Miell wrote:
> > On Tue, 2006-10-03 at 03:22 +0200, Adrian Bunk wrote:
> > > On Tue, Oct 03, 2006 at 01:44:28AM +0200, Adrian Bunk wrote:
> > > > On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
> > > >
> > > > > Hello:
> > > >
> > > > Hi Judith,
> > > >
> > > > > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > > > > 'allmodconfig' is failing. The warnings/errors below appear in
> > > > > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
> > > >
> > > > known for ages - the drivers need fixing.
> > > >
> > > > You might want to convince Andrew accepting my patch to make
> > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > people more aware of this problem...
> > > >...
> > >
> > > In case anyone is interested, the patch is below.
> > >
> > > cu
> > > Adrian
> > >
> >
> > Won't this also cause warnings for valid arch-specific usage (i.e. in
> > linux/arch/{i386,x86_64})?
>
> They aren't used under linux/arch/i386/ and my patch doesn't change x86_64.
Sorry, for some reason I thought isa_bus_to_virt and isa_virt_to_bus
were defined in terms of virt_to_bus/bus_to_virt instead of
virt_to_phys/phys_to_virt.
--
Nicholas Miell <nmiell@comcast.net>
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 1:48 ` Nicholas Miell
@ 2006-10-03 4:37 ` Benjamin Herrenschmidt
-1 siblings, 0 replies; 37+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-03 4:37 UTC (permalink / raw)
To: Nicholas Miell; +Cc: linuxppc-dev, Judith Lebzelter, linux-kernel, Adrian Bunk
> Won't this also cause warnings for valid arch-specific usage (i.e. in
> linux/arch/{i386,x86_64})?
I wouldn't cause that usage valid :)
Ben.
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 4:37 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 37+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-03 4:37 UTC (permalink / raw)
To: Nicholas Miell; +Cc: Adrian Bunk, linuxppc-dev, Judith Lebzelter, linux-kernel
> Won't this also cause warnings for valid arch-specific usage (i.e. in
> linux/arch/{i386,x86_64})?
I wouldn't cause that usage valid :)
Ben.
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 4:37 ` Benjamin Herrenschmidt
@ 2006-10-03 11:29 ` Alan Cox
-1 siblings, 0 replies; 37+ messages in thread
From: Alan Cox @ 2006-10-03 11:29 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: linuxppc-dev, Nicholas Miell, Judith Lebzelter, linux-kernel,
Adrian Bunk
Ar Maw, 2006-10-03 am 14:37 +1000, ysgrifennodd Benjamin Herrenschmidt:
> > Won't this also cause warnings for valid arch-specific usage (i.e. in
> > linux/arch/{i386,x86_64})?
>
> I wouldn't cause that usage valid :)
Actually a lot of the older legitimate users (DRM/AGP) have been cleaned
up so it might be worth doing now after all.
Ok I take back the NAK having looked deeper. We appear to have made
sufficient progress along the way.
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 11:29 ` Alan Cox
0 siblings, 0 replies; 37+ messages in thread
From: Alan Cox @ 2006-10-03 11:29 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Nicholas Miell, Adrian Bunk, linuxppc-dev, Judith Lebzelter,
linux-kernel
Ar Maw, 2006-10-03 am 14:37 +1000, ysgrifennodd Benjamin Herrenschmidt:
> > Won't this also cause warnings for valid arch-specific usage (i.e. in
> > linux/arch/{i386,x86_64})?
>
> I wouldn't cause that usage valid :)
Actually a lot of the older legitimate users (DRM/AGP) have been cleaned
up so it might be worth doing now after all.
Ok I take back the NAK having looked deeper. We appear to have made
sufficient progress along the way.
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 1:22 ` Adrian Bunk
@ 2006-10-03 4:37 ` Benjamin Herrenschmidt
-1 siblings, 0 replies; 37+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-03 4:37 UTC (permalink / raw)
To: Andrew Morton
Cc: linuxppc-dev, Judith Lebzelter, Linux Kernel list, Adrian Bunk
> > You might want to convince Andrew accepting my patch to make
> > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > people more aware of this problem...
> >...
Andrew, is there any reason not to take that patch ?
> <-- snip -->
>
>
> virt_to_bus/bus_to_virt are long deprecated, mark them as __deprecated
> on i386.
>
> Without such warnings people will never update their code and fix
> the errors in PPC64 builds.
>
> And yes, some of the drivers affected are maintained.
>
> This also catches accidential additions of users for these functions
> like a usage of bus_to_virt() in the infiniband code that was added in
> 2.6.17-rc1 (already removed).
>
> This patch increases the number of warnings shown during builds, but it
> seems worth including it at least in -mm for making people aware of this
> issue.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 7 Jul 2006
> - 26 Jun 2006
> - 27 Apr 2006
> - 19 Apr 2006
> - 6 Jan 2006
> - 13 Dec 2005
> - 23 Nov 2005
> - 18 Nov 2005
> - 12 Nov 2005
>
> --- linux-2.6.14-mm2-full/include/asm-i386/io.h.old 2005-11-12 01:44:38.000000000 +0100
> +++ linux-2.6.14-mm2-full/include/asm-i386/io.h 2005-11-12 01:45:58.000000000 +0100
> @@ -144,8 +144,14 @@
> *
> * Allow them on x86 for legacy drivers, though.
> */
> -#define virt_to_bus virt_to_phys
> -#define bus_to_virt phys_to_virt
> +static inline unsigned long __deprecated virt_to_bus(volatile void * address)
> +{
> + return __pa(address);
> +}
> +static inline void * __deprecated bus_to_virt(unsigned long address)
> +{
> + return __va(address);
> +}
>
> /*
> * readX/writeX() are used to access memory mapped devices. On some
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 4:37 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 37+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-03 4:37 UTC (permalink / raw)
To: Andrew Morton
Cc: Judith Lebzelter, linuxppc-dev, Linux Kernel list, Adrian Bunk
> > You might want to convince Andrew accepting my patch to make
> > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > people more aware of this problem...
> >...
Andrew, is there any reason not to take that patch ?
> <-- snip -->
>
>
> virt_to_bus/bus_to_virt are long deprecated, mark them as __deprecated
> on i386.
>
> Without such warnings people will never update their code and fix
> the errors in PPC64 builds.
>
> And yes, some of the drivers affected are maintained.
>
> This also catches accidential additions of users for these functions
> like a usage of bus_to_virt() in the infiniband code that was added in
> 2.6.17-rc1 (already removed).
>
> This patch increases the number of warnings shown during builds, but it
> seems worth including it at least in -mm for making people aware of this
> issue.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 7 Jul 2006
> - 26 Jun 2006
> - 27 Apr 2006
> - 19 Apr 2006
> - 6 Jan 2006
> - 13 Dec 2005
> - 23 Nov 2005
> - 18 Nov 2005
> - 12 Nov 2005
>
> --- linux-2.6.14-mm2-full/include/asm-i386/io.h.old 2005-11-12 01:44:38.000000000 +0100
> +++ linux-2.6.14-mm2-full/include/asm-i386/io.h 2005-11-12 01:45:58.000000000 +0100
> @@ -144,8 +144,14 @@
> *
> * Allow them on x86 for legacy drivers, though.
> */
> -#define virt_to_bus virt_to_phys
> -#define bus_to_virt phys_to_virt
> +static inline unsigned long __deprecated virt_to_bus(volatile void * address)
> +{
> + return __pa(address);
> +}
> +static inline void * __deprecated bus_to_virt(unsigned long address)
> +{
> + return __va(address);
> +}
>
> /*
> * readX/writeX() are used to access memory mapped devices. On some
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 4:37 ` Benjamin Herrenschmidt
@ 2006-10-03 4:44 ` Andrew Morton
-1 siblings, 0 replies; 37+ messages in thread
From: Andrew Morton @ 2006-10-03 4:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Adrian Bunk, linuxppc-dev, Judith Lebzelter, Kernel list, Linux
On Tue, 03 Oct 2006 14:37:25 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > > You might want to convince Andrew accepting my patch to make
> > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > people more aware of this problem...
> > >...
>
> Andrew, is there any reason not to take that patch ?
It generates lots of warnings from drivers which nobody does any work on.
Net result: lots of new warnings, no fixed bugs.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 4:44 ` Andrew Morton
0 siblings, 0 replies; 37+ messages in thread
From: Andrew Morton @ 2006-10-03 4:44 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Judith Lebzelter, linuxppc-dev, Linux Kernel list, Adrian Bunk
On Tue, 03 Oct 2006 14:37:25 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > > You might want to convince Andrew accepting my patch to make
> > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > people more aware of this problem...
> > >...
>
> Andrew, is there any reason not to take that patch ?
It generates lots of warnings from drivers which nobody does any work on.
Net result: lots of new warnings, no fixed bugs.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 4:44 ` Andrew Morton
@ 2006-10-03 4:49 ` Benjamin Herrenschmidt
-1 siblings, 0 replies; 37+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-03 4:49 UTC (permalink / raw)
To: Andrew Morton
Cc: linuxppc-dev, Judith Lebzelter, Linux Kernel list, Adrian Bunk
On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> On Tue, 03 Oct 2006 14:37:25 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > > > You might want to convince Andrew accepting my patch to make
> > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > people more aware of this problem...
> > > >...
> >
> > Andrew, is there any reason not to take that patch ?
>
> It generates lots of warnings from drivers which nobody does any work on.
>
> Net result: lots of new warnings, no fixed bugs.
Are you sure the warnings won't cause somebody like Al to go through
them all and fix them ?
At least they should be marked either CONFIG_BROKEN or X86 only (or
whatever arch they are supposed to be used on).
Ben.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 4:49 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 37+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-03 4:49 UTC (permalink / raw)
To: Andrew Morton
Cc: Judith Lebzelter, linuxppc-dev, Linux Kernel list, Adrian Bunk
On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> On Tue, 03 Oct 2006 14:37:25 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > > > You might want to convince Andrew accepting my patch to make
> > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > people more aware of this problem...
> > > >...
> >
> > Andrew, is there any reason not to take that patch ?
>
> It generates lots of warnings from drivers which nobody does any work on.
>
> Net result: lots of new warnings, no fixed bugs.
Are you sure the warnings won't cause somebody like Al to go through
them all and fix them ?
At least they should be marked either CONFIG_BROKEN or X86 only (or
whatever arch they are supposed to be used on).
Ben.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 4:49 ` Benjamin Herrenschmidt
@ 2006-10-03 4:55 ` Andrew Morton
-1 siblings, 0 replies; 37+ messages in thread
From: Andrew Morton @ 2006-10-03 4:55 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Adrian Bunk, linuxppc-dev, Judith Lebzelter, Kernel list, Linux
On Tue, 03 Oct 2006 14:49:39 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> > On Tue, 03 Oct 2006 14:37:25 +1000
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > > > You might want to convince Andrew accepting my patch to make
> > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > > people more aware of this problem...
> > > > >...
> > >
> > > Andrew, is there any reason not to take that patch ?
> >
> > It generates lots of warnings from drivers which nobody does any work on.
> >
> > Net result: lots of new warnings, no fixed bugs.
>
> Are you sure the warnings won't cause somebody like Al to go through
> them all and fix them ?
The drivers simply don't link on some architectures, due to missing
virt_to_bus/bus_to_virt. They aren't hard to find.
> At least they should be marked either CONFIG_BROKEN or X86 only (or
> whatever arch they are supposed to be used on).
>
Something like that would make sense. I guess a new config option.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 4:55 ` Andrew Morton
0 siblings, 0 replies; 37+ messages in thread
From: Andrew Morton @ 2006-10-03 4:55 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Judith Lebzelter, linuxppc-dev, Linux Kernel list, Adrian Bunk
On Tue, 03 Oct 2006 14:49:39 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> > On Tue, 03 Oct 2006 14:37:25 +1000
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > > > You might want to convince Andrew accepting my patch to make
> > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > > people more aware of this problem...
> > > > >...
> > >
> > > Andrew, is there any reason not to take that patch ?
> >
> > It generates lots of warnings from drivers which nobody does any work on.
> >
> > Net result: lots of new warnings, no fixed bugs.
>
> Are you sure the warnings won't cause somebody like Al to go through
> them all and fix them ?
The drivers simply don't link on some architectures, due to missing
virt_to_bus/bus_to_virt. They aren't hard to find.
> At least they should be marked either CONFIG_BROKEN or X86 only (or
> whatever arch they are supposed to be used on).
>
Something like that would make sense. I guess a new config option.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 4:55 ` Andrew Morton
@ 2006-10-03 5:07 ` Adrian Bunk
-1 siblings, 0 replies; 37+ messages in thread
From: Adrian Bunk @ 2006-10-03 5:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: Judith Lebzelter, Linux Kernel list, linuxppc-dev
On Mon, Oct 02, 2006 at 09:55:27PM -0700, Andrew Morton wrote:
> On Tue, 03 Oct 2006 14:49:39 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> > > On Tue, 03 Oct 2006 14:37:25 +1000
> > > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > >
> > > > > > You might want to convince Andrew accepting my patch to make
> > > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > > > people more aware of this problem...
> > > > > >...
> > > >
> > > > Andrew, is there any reason not to take that patch ?
> > >
> > > It generates lots of warnings from drivers which nobody does any work on.
> > >
> > > Net result: lots of new warnings, no fixed bugs.
> >
> > Are you sure the warnings won't cause somebody like Al to go through
> > them all and fix them ?
>
> The drivers simply don't link on some architectures, due to missing
> virt_to_bus/bus_to_virt. They aren't hard to find.
>...
As my patch description says, there had even been one bus_to_virt()
accidentally added in 2.6.17-rc1.
Shouldn't people become aware of it as early and as often as possible?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 37+ messages in thread* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 5:07 ` Adrian Bunk
0 siblings, 0 replies; 37+ messages in thread
From: Adrian Bunk @ 2006-10-03 5:07 UTC (permalink / raw)
To: Andrew Morton
Cc: Benjamin Herrenschmidt, Judith Lebzelter, linuxppc-dev,
Linux Kernel list
On Mon, Oct 02, 2006 at 09:55:27PM -0700, Andrew Morton wrote:
> On Tue, 03 Oct 2006 14:49:39 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> > > On Tue, 03 Oct 2006 14:37:25 +1000
> > > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > >
> > > > > > You might want to convince Andrew accepting my patch to make
> > > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > > > people more aware of this problem...
> > > > > >...
> > > >
> > > > Andrew, is there any reason not to take that patch ?
> > >
> > > It generates lots of warnings from drivers which nobody does any work on.
> > >
> > > Net result: lots of new warnings, no fixed bugs.
> >
> > Are you sure the warnings won't cause somebody like Al to go through
> > them all and fix them ?
>
> The drivers simply don't link on some architectures, due to missing
> virt_to_bus/bus_to_virt. They aren't hard to find.
>...
As my patch description says, there had even been one bus_to_virt()
accidentally added in 2.6.17-rc1.
Shouldn't people become aware of it as early and as often as possible?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 4:49 ` Benjamin Herrenschmidt
@ 2006-10-03 9:36 ` Stefan Richter
-1 siblings, 0 replies; 37+ messages in thread
From: Stefan Richter @ 2006-10-03 9:36 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Andrew Morton, linuxppc-dev, Judith Lebzelter, Linux Kernel list,
Adrian Bunk
Benjamin Herrenschmidt wrote:
> On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
>> Net result: lots of new warnings, no fixed bugs.
>
> Are you sure the warnings won't cause somebody like Al to go through
> them all and fix them ?
If you mean by "fix" to actually convert to generic DMA mapping, then
this task may turn out to require in-depth knowledge of the driver and
its field of application in some or many of these cases.
--
Stefan Richter
-=====-=-==- =-=- ---==
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 9:36 ` Stefan Richter
0 siblings, 0 replies; 37+ messages in thread
From: Stefan Richter @ 2006-10-03 9:36 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Andrew Morton, Judith Lebzelter, linuxppc-dev, Linux Kernel list,
Adrian Bunk
Benjamin Herrenschmidt wrote:
> On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
>> Net result: lots of new warnings, no fixed bugs.
>
> Are you sure the warnings won't cause somebody like Al to go through
> them all and fix them ?
If you mean by "fix" to actually convert to generic DMA mapping, then
this task may turn out to require in-depth knowledge of the driver and
its field of application in some or many of these cases.
--
Stefan Richter
-=====-=-==- =-=- ---==
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
2006-10-03 1:22 ` Adrian Bunk
@ 2006-10-03 11:24 ` Alan Cox
-1 siblings, 0 replies; 37+ messages in thread
From: Alan Cox @ 2006-10-03 11:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, Judith Lebzelter, linux-kernel
Ar Maw, 2006-10-03 am 03:22 +0200, ysgrifennodd Adrian Bunk:
> This patch was already sent on:
> - 7 Jul 2006
> - 26 Jun 2006
> - 27 Apr 2006
> - 19 Apr 2006
> - 6 Jan 2006
> - 13 Dec 2005
> - 23 Nov 2005
> - 18 Nov 2005
> - 12 Nov 2005
This patch was already NAKed on
...
These functions are used internally in the x86 core code correctly and
validly. It's just as easy to find the offenders with grep or building a
PPC tree.
^ permalink raw reply [flat|nested] 37+ messages in thread
* Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
@ 2006-10-03 11:24 ` Alan Cox
0 siblings, 0 replies; 37+ messages in thread
From: Alan Cox @ 2006-10-03 11:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Judith Lebzelter, linux-kernel, linuxppc-dev
Ar Maw, 2006-10-03 am 03:22 +0200, ysgrifennodd Adrian Bunk:
> This patch was already sent on:
> - 7 Jul 2006
> - 26 Jun 2006
> - 27 Apr 2006
> - 19 Apr 2006
> - 6 Jan 2006
> - 13 Dec 2005
> - 23 Nov 2005
> - 18 Nov 2005
> - 12 Nov 2005
This patch was already NAKed on
...
These functions are used internally in the x86 core code correctly and
validly. It's just as easy to find the offenders with grep or building a
PPC tree.
^ permalink raw reply [flat|nested] 37+ messages in thread