From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederik Deweerdt Date: Tue, 03 Oct 2006 08:10:22 +0000 Subject: Re: [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check Message-Id: <20061003081022.GD2785@slug> List-Id: References: <20061003075607.32837.qmail@web55612.mail.re4.yahoo.com> In-Reply-To: <20061003075607.32837.qmail@web55612.mail.re4.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Tue, Oct 03, 2006 at 12:56:07AM -0700, Amit Choudhary wrote: > Description: Check the return value of kmalloc() in function snd_card_ad1816a_pnp(), in file sound/isa/ad1816a/ad1816a.c. It seems that your mailer converts the tabs to white spaces, that's why your patch cannot be applied. Regards, Frederik > > Signed-off-by: Amit Choudhary > > diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c > index b33a5fb..fab77ae 100644 > --- a/sound/isa/ad1816a/ad1816a.c > +++ b/sound/isa/ad1816a/ad1816a.c > @@ -120,6 +120,8 @@ static int __devinit snd_card_ad1816a_pn > struct pnp_resource_table *cfg = kmalloc(sizeof(*cfg), GFP_KERNEL); > int err; > > + if(!cfg) > + return -ENOMEM; > acard->dev = pnp_request_card_device(card, id->devs[0].id, NULL); > if (acard->dev = NULL) { > kfree(cfg); > > > > _______________________________________________ > Kernel-janitors mailing list > Kernel-janitors@lists.osdl.org > https://lists.osdl.org/mailman/listinfo/kernel-janitors > _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors