From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: Infinite loop on reboot with 3.0.3 and crash_debug=y Date: Tue, 3 Oct 2006 23:16:56 +0200 Message-ID: <20061003211656.GC5972@rhun.haifa.ibm.com> References: <4522D0D7.1070105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4522D0D7.1070105@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Chris Lalancette Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Oct 03, 2006 at 05:06:31PM -0400, Chris Lalancette wrote: > But because the dom0 has gone away, we are not in guest mode > anymore, and so we hit the panic. The panic is handled in > drivers/char/console.c, which has another call to > debugger_trap_immediate, which generates the int3, which gets us > into the infinite loop. Reverting the change noted above goes back > to the old behavior (i.e. actually rebooting :). I'm tempted to say > the debugger_trap_immediate has no business being in the panic > function, but I'd like to hear other opinions on it. Last time I checked, dom0 was pretty good about using the correct SHUTDOWN_xxx flag to indicate whether this is a "planned" shutdown or a panic. Calling into debugger_trap_immediate() may be fine for a panic (assuming there's a debugger there to avoid the infinite loop...) but doesn't make sense for planned shutdown. My .02 ILS. Cheers, Muli