diff for duplicates of <200610040019.43028.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index 0cbab91..6da5ad4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,20 +1,18 @@ On Tuesday 03 October 2006 22:57, Linas Vepstas wrote: -> +=A0=A0=A0=A0=A0=A0=A0if ((chain->head->next =3D=3D chain->tail->prev) || -> +=A0=A0=A0=A0=A0=A0=A0 =A0 (spider_net_get_descr_status(descr) !=3D SPIDE= -R_NET_DESCR_NOT_IN_USE)) { -> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0result =3D NETDEV_TX_LOCK= -ED; -> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0goto out; -> =A0=A0=A0=A0=A0=A0=A0=A0} +> + if ((chain->head->next == chain->tail->prev) || +> + (spider_net_get_descr_status(descr) != SPIDER_NET_DESCR_NOT_IN_USE)) { +> result = NETDEV_TX_LOCKED; +> goto out; +> } -=2E.. +... -> =A0out: -> -=A0=A0=A0=A0=A0=A0=A0netif_wake_queue(netdev); -> +=A0=A0=A0=A0=A0=A0=A0card->netdev_stats.tx_dropped++; -> +=A0=A0=A0=A0=A0=A0=A0netif_stop_queue(netdev); -> =A0=A0=A0=A0=A0=A0=A0=A0return result; -> =A0} +> out: +> - netif_wake_queue(netdev); +> + card->netdev_stats.tx_dropped++; +> + netif_stop_queue(netdev); +> return result; +> } Hmm, this looks a little strange to me. I would assume that we should not stop the queue when the device is locked, but only when it is busy. diff --git a/a/content_digest b/N1/content_digest index 893ba28..3588709 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,22 +13,20 @@ "\00:1\0" "b\0" "On Tuesday 03 October 2006 22:57, Linas Vepstas wrote:\n" - "> +=A0=A0=A0=A0=A0=A0=A0if ((chain->head->next =3D=3D chain->tail->prev) ||\n" - "> +=A0=A0=A0=A0=A0=A0=A0 =A0 (spider_net_get_descr_status(descr) !=3D SPIDE=\n" - "R_NET_DESCR_NOT_IN_USE)) {\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0result =3D NETDEV_TX_LOCK=\n" - "ED;\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0goto out;\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0}\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if ((chain->head->next == chain->tail->prev) ||\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 \302\240 (spider_net_get_descr_status(descr) != SPIDER_NET_DESCR_NOT_IN_USE)) {\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240result = NETDEV_TX_LOCKED;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240goto out;\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "\n" - "=2E..\n" + "...\n" "\n" - "> =A0out:\n" - "> -=A0=A0=A0=A0=A0=A0=A0netif_wake_queue(netdev);\n" - "> +=A0=A0=A0=A0=A0=A0=A0card->netdev_stats.tx_dropped++;\n" - "> +=A0=A0=A0=A0=A0=A0=A0netif_stop_queue(netdev);\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0return result;\n" - "> =A0}\n" + "> \302\240out:\n" + "> -\302\240\302\240\302\240\302\240\302\240\302\240\302\240netif_wake_queue(netdev);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240card->netdev_stats.tx_dropped++;\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240netif_stop_queue(netdev);\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return result;\n" + "> \302\240}\n" "\n" "Hmm, this looks a little strange to me. I would assume that we should not\n" "stop the queue when the device is locked, but only when it is busy.\n" @@ -39,4 +37,4 @@ "\n" "\tArnd <><" -e57546f231e1a6b62f794cd02cb249d2552702045d473ed14f5ee7c08726d152 +4f303343906b7ea8c7912ea56dd50d07d72cabe24494612cc287a5c95f1ddb54
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.