From: Greg KH <gregkh@suse.de>
To: Jarek Poplawski <jarkao2@o2.pl>,
"Axel C. Voigt" <Axel.Voigt@qosmotec.com>,
linux-kernel@vger.kernel.org, David Kubicek <dave@awk.cz>
Subject: Re: Problems with hard irq? (inconsistent lock state)
Date: Tue, 3 Oct 2006 22:43:09 -0700 [thread overview]
Message-ID: <20061004054309.GA387@suse.de> (raw)
In-Reply-To: <20061004054308.GA994@ff.dom.local>
On Wed, Oct 04, 2006 at 07:43:08AM +0200, Jarek Poplawski wrote:
> On 29-09-2006 13:45, Axel C. Voigt wrote:
> >
> > Hello all,
> >
> > today I received the following stack backtrace using debian-2.6.18 with our communications driver accessing a ACM device. This happened when removing (powering off and/or on) the mobile phone (nokia 6630) at /dev/ttyACMx
> >
> > Are someone able to get a hint for me?
> >
> > --schnipp--
> > Sep 29 13:29:53 mcs70 kernel:
> > Sep 29 13:29:53 mcs70 kernel: =================================
> > Sep 29 13:29:53 mcs70 kernel: [ INFO: inconsistent lock state ]
> > Sep 29 13:29:53 mcs70 kernel: ---------------------------------
> > Sep 29 13:29:53 mcs70 kernel: inconsistent {hardirq-on-W} -> {in-hardirq-W} usage.
> > Sep 29 13:29:53 mcs70 kernel: startDV24/3864 [HC1[1]:SC0[0]:HE0:SE1] takes:
> > Sep 29 13:29:53 mcs70 kernel: (&acm->read_lock){++..}, at: [<e08952d8>] acm_read_bulk+0x60/0xde [cdc_acm]
> > Sep 29 13:29:53 mcs70 kernel: {hardirq-on-W} state was registered at:
> > Sep 29 13:29:53 mcs70 kernel: [<c01321f3>] lock_acquire+0x56/0x73
> > Sep 29 13:29:53 mcs70 kernel: [<c02ce42a>] _spin_lock+0x1a/0x25
> > Sep 29 13:29:53 mcs70 kernel: [<e08953a8>] acm_rx_tasklet+0x52/0x2be [cdc_acm]
> > Sep 29 13:29:53 mcs70 kernel: [<c011f868>] tasklet_action+0x6d/0xd7
> > Sep 29 13:29:53 mcs70 kernel: [<c011f526>] __do_softirq+0x79/0xf2
> ...
> > Sep 29 13:29:53 mcs70 kernel: stack backtrace:
> > Sep 29 13:29:53 mcs70 kernel: [<c010376e>] show_trace+0x16/0x18
> > Sep 29 13:29:53 mcs70 kernel: [<c010383c>] dump_stack+0x19/0x1b
> > Sep 29 13:29:53 mcs70 kernel: [<c0130ad8>] print_usage_bug+0x1e1/0x1eb
> > Sep 29 13:29:53 mcs70 kernel: [<c0130b86>] mark_lock+0xa4/0x4d9
> > Sep 29 13:29:53 mcs70 kernel: [<c0131823>] __lock_acquire+0x41a/0x841
> > Sep 29 13:29:53 mcs70 kernel: [<c01321f3>] lock_acquire+0x56/0x73
> > Sep 29 13:29:53 mcs70 kernel: [<c02ce42a>] _spin_lock+0x1a/0x25
> > Sep 29 13:29:53 mcs70 kernel: [<e08952d8>] acm_read_bulk+0x60/0xde [cdc_acm]
> ...
> > Sep 29 13:29:53 mcs70 kernel: [<c0104b26>] do_IRQ+0x4e/0x5f
> > Sep 29 13:29:53 mcs70 kernel: [<c0103339>] common_interrupt+0x25/0x2c
> ...
>
> It looks in drivers/usb/class/cdc-acm.c acm_rx_tasklet could be preempted
> with acm->read_lock by acm_read_bulk which uses the same lock from hardirq
> context.
>
> So probably spin_lock_irqsave is needed.
Yup. Care to send a patch?
thanks,
greg k-h
next prev parent reply other threads:[~2006-10-04 5:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 11:45 Problems with hard irq? (inconsistent lock state) Axel C. Voigt
2006-10-04 5:43 ` Jarek Poplawski
2006-10-04 5:43 ` Greg KH [this message]
2006-10-04 6:45 ` Jarek Poplawski
2006-10-05 18:05 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2006-10-04 20:58 Axel C. Voigt
2006-10-05 8:39 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061004054309.GA387@suse.de \
--to=gregkh@suse.de \
--cc=Axel.Voigt@qosmotec.com \
--cc=dave@awk.cz \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.