All of lore.kernel.org
 help / color / mirror / Atom feed
From: pcaulfield@sourceware.org <pcaulfield@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/group/dlm_controld action.c dlm_daemon ...
Date: 5 Oct 2006 07:52:50 -0000	[thread overview]
Message-ID: <20061005075250.3187.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Changes by:	pcaulfield at sourceware.org	2006-10-05 07:52:50

Modified files:
	group/dlm_controld: action.c dlm_daemon.h member_cman.c 

Log message:
	A bit of a hack to cope with the race condition where dlm_controld gets
	the groupd callback before the cman one and tries to start a DLM lockspace
	before all the node addresses are known.
	
	I think this will fix bz#207197

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/dlm_controld/action.c.diff?cvsroot=cluster&r1=1.6&r2=1.7
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/dlm_controld/dlm_daemon.h.diff?cvsroot=cluster&r1=1.3&r2=1.4
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/group/dlm_controld/member_cman.c.diff?cvsroot=cluster&r1=1.2&r2=1.3

--- cluster/group/dlm_controld/action.c	2006/08/31 18:17:00	1.6
+++ cluster/group/dlm_controld/action.c	2006/10/05 07:52:50	1.7
@@ -297,6 +297,8 @@
 		if (id_exists(id, old_count, old_members))
 			continue;
 
+		if (!is_cman_member(id))
+			cman_statechange();
 		/*
 		 * create node's dir
 		 */
--- cluster/group/dlm_controld/dlm_daemon.h	2006/07/19 14:44:40	1.3
+++ cluster/group/dlm_controld/dlm_daemon.h	2006/10/05 07:52:50	1.4
@@ -94,5 +94,9 @@
 struct lockspace *create_ls(char *name);
 struct lockspace *find_ls(char *name);
 
+/* member_cman.c */
+int is_cman_member(int nodeid);
+void cman_statechange(void);
+
 #endif
 
--- cluster/group/dlm_controld/member_cman.c	2006/06/30 15:36:52	1.2
+++ cluster/group/dlm_controld/member_cman.c	2006/10/05 07:52:50	1.3
@@ -66,6 +66,7 @@
 	return cn->cn_name;
 }
 
+
 /* add a configfs dir for cluster members that don't have one,
    del the configfs dir for cluster members that are now gone */
 
@@ -219,3 +220,8 @@
 	return fd;
 }
 
+/* Force re-read of cman nodes */
+void cman_statechange()
+{
+	statechange();
+}



             reply	other threads:[~2006-10-05  7:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-05  7:52 pcaulfield [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-10-24 16:16 [Cluster-devel] cluster/group/dlm_controld action.c dlm_daemon teigland
2007-01-09 19:17 teigland
2007-01-09 19:18 teigland
2007-04-23 15:24 teigland
2007-04-23 15:31 teigland
2007-05-04 21:05 teigland
2007-05-04 21:14 teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061005075250.3187.qmail@sourceware.org \
    --to=pcaulfield@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.