From: David Chinner <dgc@sgi.com>
To: Timothy Shimmin <tes@sgi.com>
Cc: xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: review: xfs_copy fix
Date: Fri, 6 Oct 2006 16:36:43 +1000 [thread overview]
Message-ID: <20061006063643.GD11034@melbourne.sgi.com> (raw)
In-Reply-To: <5635EC4CFB723E7E36B51235@timothy-shimmins-power-mac-g5.local>
On Fri, Oct 06, 2006 at 04:18:10PM +1000, Timothy Shimmin wrote:
> Request for review.
>
> xfs_copy was seg faulting for me on my x86_64 box.
> This fixes up the variable arg handling for multiple
> vfprintf calls by putting va_start and va_end calls
> around them (never done this before:).
I take it that it was crashing because the LOG flag and one
of ERR or OUT was set so it was trying to do 2 varargs
traversals with only one init?
Looks sane to me.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2006-10-06 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 6:18 review: xfs_copy fix Timothy Shimmin
2006-10-06 6:36 ` David Chinner [this message]
2006-10-06 7:15 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006063643.GD11034@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.