From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Smith Subject: Re: [PATCH] xm reboot/shutdown/sysrq to HVM domain Date: Fri, 6 Oct 2006 10:59:03 +0100 Message-ID: <20061006095902.GA2767@cam.ac.uk> References: <4526005B.1020906@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1198035712==" Return-path: In-Reply-To: <4526005B.1020906@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tetsu Yamamoto Cc: xen-devel@lists.xensource.com, sos22@srcf.ucam.org List-Id: xen-devel@lists.xenproject.org --===============1198035712== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > This patch enhances 'xm reboot'/'xm shutdown' commands to > reboot/shutdown guest Linux on HVM domain as gracefully as para-Linux. > In addtion, sysrq key signal can be sent to HVM domain by 'xm sysrq' > command. Thanks, that's really useful. I have a couple of comments about the patch, though: -- It looks like you had some problems with ctrl_alt_del(), and instead used kill_proc(cad_pid, SIGINT, 1). What was the reason for this? =20 -- You've introduced a lot of #ifdefs into reboot.c. It might be easier to just split the file in two; did you look at this at all? -- You set reboot_module from within a xenbus transaction. I don't think that's necessary, since xenbus_writes are supposed to be atomic anyway. -- Because of the way mkbuildtree works, you're going to create symlinks from unmodified-drivers to all of the files in linux-2.6-xen-sparse/drivers/core, rather than just to reboot.c. It's a trivial aesthetic issue, but it'd be nice not to create lots of useless symlinks. Apart from that, it looks pretty reasonable. Steven. --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFFJijmO4S8/gLNrjcRAvSBAKCpVMI1zCJAGgj7KGlv+BZEVFt/vgCfZToR wFMX8feUX/iWgc3tT7EqM9w= =GjGB -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z-- --===============1198035712== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1198035712==--