From: Jens Axboe <jens.axboe@oracle.com>
To: Arjan van de Ven <arjan@fenrus.demon.nl>
Cc: Stephen Hemminger <shemminger@osdl.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: lockdep warning looks scsi related
Date: Fri, 6 Oct 2006 19:19:26 +0200 [thread overview]
Message-ID: <20061006171926.GC8814@kernel.dk> (raw)
In-Reply-To: <1160140963.3000.106.camel@laptopd505.fenrus.org>
On Fri, Oct 06 2006, Arjan van de Ven wrote:
> On Thu, 2006-10-05 at 10:08 -0700, Stephen Hemminger wrote:
> > This is current main linux-2.6 (git pulled yesterday).
> > Running on 2 CPU Opteron
> > Happened during overnight (beagle cronjob?)
>
> hmm lots of changes in cfq, and to be honest the
> cfq_exit_single_io_context() change makes me nervous.
> The comment says it's called with interrupts disabled, what the comment
> does NOT say is that this function ENABLES interrupts!
> (the entire cfq change has many places where interrupts now get enabled
> where previously they remained as is... )
The comment is stale, it isn't called with interrupts disabled (or the
spin_lock_irq() and unlock would be buggy). The lockdep trace is
interesting though, added to the list of things to investigate ASAP.
--
Jens Axboe
prev parent reply other threads:[~2006-10-06 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 17:08 lockdep warning looks scsi related Stephen Hemminger
2006-10-06 13:22 ` Arjan van de Ven
2006-10-06 17:19 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006171926.GC8814@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=arjan@fenrus.demon.nl \
--cc=linux-scsi@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.