Re: [PATCH 2.6.19-rc1 V9] drivers: add LCD support

[Pavel Machek <pavel@ucw.cz>]

Hi!

> >Yep... but when we have /dev/fbcfag12864b ... do we need
> >/dev/cfag12864bX ? I think it is useless at that point.
> 
> Well, because cfag12864b is the generic one I think it should be in
> the /dev directory (whatever if you use or don't it / whatever if it
> is useless or not).

I do not understand, both /dev/fbcfag12864b and /dev/cfag12864bX are
in /dev/...

What is advantage of /dev/cfag12864bX over /dev/fbcfag12864b ?

(And I guess you should invent better name... /dev/fbaux0?)

> >/dev/fbcfag12864b is very easy to "manipulate by hand" too.
> 
> Yep, IMO we should add a Kconfig option instead of mixing both by
> default (cfag12864b and fbcfag12864b); anyway I think having
> cfag12864b & fbcfag12864b is better than mixing it all in one
> module.

I do not think we need a Kconfig option, and I do not think we need
/dev/cfag12864bX . Just use /dev/fbaux0, always.

> modules as they are now and add the fbcfag12864b later in time: I'm
> waiting them to get into one of the -rcs without more radical changes.

I do not think it is suitable for -rc at this point, and it does not
have chance before 2.6.20-rc1, anyway.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html