From: Akinobu Mita <akinobu.mita@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
Date: Mon, 9 Oct 2006 20:55:26 +0900 [thread overview]
Message-ID: <20061009115526.GA10857@localhost> (raw)
In-Reply-To: <20061009111446.GA22020@gondor.apana.org.au>
On Mon, Oct 09, 2006 at 09:14:46PM +1000, Herbert Xu wrote:
> Actually, crypto_alloc_tfm is an obsolete function which is supposed
> to maintain its previous semantics of returning NULL or success.
I misunderstood about crypto_alloc_tfm().
BTW, ecryptfs and reiser4 are still using crypto_alloc_tfm().
Should we mark it as __deprecated?
> I don't quite see where the problem with crypto_alloc_base is.
- __crypto_alloc_tfm() should return -ENOMEM on kzalloc() failure.
But it returns NULL.
- crypto_alloc_base() may not return -EINTR on signal_pending()
I'll fix the patch and resend with more clear description later.
next prev parent reply other threads:[~2006-10-09 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 8:58 [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value Akinobu Mita
2006-10-09 9:01 ` [PATCH 2/2] crypto: delete duplicated code Akinobu Mita
2006-10-09 11:14 ` [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value Herbert Xu
2006-10-09 11:55 ` Akinobu Mita [this message]
2006-10-10 3:53 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009115526.GA10857@localhost \
--to=akinobu.mita@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.