All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-git] Fix error handling in create_files()
Date: Mon, 9 Oct 2006 09:48:20 -0700	[thread overview]
Message-ID: <20061009164820.GA22630@suse.de> (raw)
In-Reply-To: <20061009164017.GA13698@dreamland.darkstar.lan>

On Mon, Oct 09, 2006 at 06:40:17PM +0200, Luca Tettamanti wrote:
> Hello,
> current code in create_files() detects an error iff the last
> sysfs_add_file fails:
> 
> for (attr = grp->attrs; *attr && !error; attr++) {
>         error = sysfs_add_file(dir, *attr, SYSFS_KOBJ_ATTR);
> }
> if (error)
>         remove_files(dir,grp);
> 
> In order to do the proper cleanup upon failure 'error' must be checked on
> every iteration.

But it is, look up there in the "!error" test, right?

thanks,

greg k-h

  reply	other threads:[~2006-10-09 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-09 16:40 [PATCH 2.6.19-git] Fix error handling in create_files() Luca Tettamanti
2006-10-09 16:48 ` Greg KH [this message]
2006-10-09 17:03   ` Luca Tettamanti
2006-10-09 17:22     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061009164820.GA22630@suse.de \
    --to=gregkh@suse.de \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.