From: Paul Jackson <pj@sgi.com>
To: Paul Jackson <pj@sgi.com>
Cc: nickpiggin@yahoo.com.au, linux-mm@kvack.org, akpm@osdl.org,
rientjes@google.com, ak@suse.de, mbligh@google.com,
rohitseth@google.com, menage@google.com, clameter@sgi.com
Subject: Re: [RFC] memory page alloc minor cleanups
Date: Mon, 9 Oct 2006 18:45:02 -0700 [thread overview]
Message-ID: <20061009184502.27e515c9.pj@sgi.com> (raw)
In-Reply-To: <20061009132404.e6f8522d.pj@sgi.com>
pj wrote:
> The check is not needed right there. If we have an empty zonelist, then
> that just makes the zonelist scanning go all the faster ;). Harmless,
> silly, but rare.
I should read the code before spouting off ... ;).
The get_page_from_freelist() code assumes in many places that there
is at least one zone in the zonelist. It will barf all over the
place if zonelist->zones[0] is not a valid pointer.
Either this check for an empty zonelist at the top of __alloc_pages()
stays, or it becomes some kind of BUG() or someone more confident than
I removes it.
I'll be sending a patch to restore that check for an empty zonelist,
shortly.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-10-10 1:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 10:54 [RFC] memory page alloc minor cleanups Paul Jackson, Paul Jackson
2006-10-09 10:54 ` [RFC] memory page_alloc zonelist caching speedup Paul Jackson
2006-10-09 18:12 ` Andrew Morton
2006-10-09 22:02 ` Paul Jackson
2006-10-10 4:51 ` Paul Jackson
2006-10-10 6:34 ` David Rientjes
2006-10-10 7:03 ` Paul Jackson
2006-10-10 17:07 ` Christoph Lameter
2006-10-10 19:35 ` Paul Jackson
2006-10-10 6:45 ` Paul Jackson
2006-10-09 11:08 ` [RFC] memory page alloc minor cleanups Christoph Lameter
2006-10-09 11:50 ` Paul Jackson
2006-10-09 17:12 ` Christoph Lameter
2006-10-09 13:11 ` Nick Piggin
2006-10-09 20:24 ` Paul Jackson
2006-10-10 1:45 ` Paul Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009184502.27e515c9.pj@sgi.com \
--to=pj@sgi.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mbligh@google.com \
--cc=menage@google.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rientjes@google.com \
--cc=rohitseth@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.