From: Pavel Machek <pavel@ucw.cz>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: it's OK to pass pointer to volatile as iounmap() argument...
Date: Mon, 9 Oct 2006 19:35:35 +0000 [thread overview]
Message-ID: <20061009193534.GA4358@ucw.cz> (raw)
In-Reply-To: <20061009010949.GJ29920@ftp.linux.org.uk>
Hi!
> --- a/arch/arm/mm/ioremap.c
> +++ b/arch/arm/mm/ioremap.c
> @@ -361,14 +361,14 @@ __ioremap(unsigned long phys_addr, size_
> }
> EXPORT_SYMBOL(__ioremap);
>
> -void __iounmap(void __iomem *addr)
> +void __iounmap(volatile void __iomem *addr)
Who is crazy enough to pass volatile pointers here? I guess they should be
fixed, instead.
Pavel
--
Thanks for all the (sleeping) penguins.
prev parent reply other threads:[~2006-10-11 11:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 1:09 [PATCH] arm: it's OK to pass pointer to volatile as iounmap() argument Al Viro
2006-10-09 19:35 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009193534.GA4358@ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.